From 83febd14d8eb9d3dd60cf2f17f049302e31855b6 Mon Sep 17 00:00:00 2001 From: mveron Date: Thu, 12 Apr 2012 22:17:02 +0200 Subject: [PATCH] [SIGNED-OFF] Bug 5668 Error during during insall with web installer, Step 3 Signed-off-by: Katrin Fischer Before patch web installer dies with error message on creating database tables: ERROR 1064 (42000) at line 2821: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '- biblionumber int(11) NOT NULL, - rating_value tinyint(1) NOT NULL, - ' at line 2 After patch installation completes normally. I also checked that tables ratings and pending_offline_operations were created correctly. Note: This is Marc Veron's first patch for Koha - congratulations! --- installer/data/mysql/kohastructure.sql | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql index 71eaeb0..a210293 100644 --- a/installer/data/mysql/kohastructure.sql +++ b/installer/data/mysql/kohastructure.sql @@ -1545,6 +1545,7 @@ CREATE TABLE `patronimage` ( -- this table is MyISAM, InnoDB tables are growing only and this table is filled/emptied/filled/emptied... -- so MyISAM is better in this case +DROP TABLE IF EXISTS `pending_offline_operations`; CREATE TABLE `pending_offline_operations` ( `operationid` int(11) NOT NULL AUTO_INCREMENT, `userid` varchar(30) NOT NULL, @@ -2819,9 +2820,9 @@ CREATE TABLE IF NOT EXISTS `social_data` ( DROP TABLE IF EXISTS ratings; CREATE TABLE ratings ( - borrowernumber int(11) NOT NULL, --- the borrower this rating is for - biblionumber int(11) NOT NULL, --- the biblio it's for - rating_value tinyint(1) NOT NULL, --- the rating, from 1-5 + borrowernumber int(11) NOT NULL, -- the borrower this rating is for + biblionumber int(11) NOT NULL, -- the biblio it's for + rating_value tinyint(1) NOT NULL, -- the rating, from 1-5 timestamp timestamp NOT NULL default CURRENT_TIMESTAMP, PRIMARY KEY (borrowernumber,biblionumber), CONSTRAINT ratings_ibfk_1 FOREIGN KEY (borrowernumber) REFERENCES borrowers (borrowernumber) ON DELETE CASCADE ON UPDATE CASCADE, -- 1.7.5.4