Bugzilla – Attachment 91769 Details for
Bug 23229
"Get all requests" API call fired when loading any ILL page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23229: Only load ILL table JS when needed
Bug-23229-Only-load-ILL-table-JS-when-needed.patch (text/plain), 1.67 KB, created by
Josef Moravec
on 2019-07-25 17:00:24 UTC
(
hide
)
Description:
Bug 23229: Only load ILL table JS when needed
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2019-07-25 17:00:24 UTC
Size:
1.67 KB
patch
obsolete
>From 44a266e7569cce795dac52196c262abcef82374f Mon Sep 17 00:00:00 2001 >From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> >Date: Fri, 28 Jun 2019 10:24:32 +0100 >Subject: [PATCH] Bug 23229: Only load ILL table JS when needed > >This patch prevents the JS associated with the ILL table from loading >unless we're actually displaying the table. This has the knock on effect >of not causing the "get all ILL requests" API request to fire when >loading any ILL page. > >Test plan: > >- Go to "ILL requests" page >- TEST: Observe that the table loads all ILL requests >- Go to the "New ILL request" page for any installed backend >- TEST: Check the browser dev tools "Network" panel, observe that the >/api/v1/illrequests?embed=metadata,patron,capabilities,library,status_alias,comments,requested_partners >request is not made. > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >index a39b93c235..d147e55d0f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >@@ -540,8 +540,10 @@ > // Set column settings > var columns_settings = [% ColumnsSettings.GetColumns( 'illrequests', 'ill-requests', 'ill-requests', 'json' ) %]; > </script> >+ [% IF query_type == 'illlist' %] > [% INCLUDE 'ill-list-table-strings.inc' %] > [% Asset.js("js/ill-list-table.js") | $raw %] >+ [% END %] > [% END %] > > [% TRY %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23229
:
91062
|
91096
|
91097
|
91769
|
91770
|
92491
|
92492
|
92493
|
92494