Bugzilla – Attachment 91772 Details for
Bug 23363
Clicking on shipping cost invoice link from spent.pl causes internal server error
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23363: Fix Internal Server Error when clicking on shipment cost invoice link
Bug-23363-Fix-Internal-Server-Error-when-clicking-.patch (text/plain), 2.37 KB, created by
Josef Moravec
on 2019-07-25 17:55:35 UTC
(
hide
)
Description:
Bug 23363: Fix Internal Server Error when clicking on shipment cost invoice link
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2019-07-25 17:55:35 UTC
Size:
2.37 KB
patch
obsolete
>From 4ed314df479172b27e32a515a4ca1c4d2077829a Mon Sep 17 00:00:00 2001 >From: Liz Rea <wizzyrea@gmail.com> >Date: Tue, 23 Jul 2019 10:22:20 -0500 >Subject: [PATCH] Bug 23363: Fix Internal Server Error when clicking on > shipment cost invoice link > >To test: > >On the fund detail page, have some shipment costs associated with a fund > >an example would be cgi-bin/koha/acqui/spent.pl?fund=<your fund>&fund_code=<your >code> > >Click the link for the fund, without this patch it will give an internal >server error. > >With this patch, the shipment invoice will be loaded. >Signed-off-by: Jason DeShaw <JDeShaw@fargolibrary.org> >Signed-off-by: Laurel Moran <lmoran@sdlawlibrary.org> > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > acqui/spent.pl | 5 +++-- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt | 2 +- > 2 files changed, 4 insertions(+), 3 deletions(-) > >diff --git a/acqui/spent.pl b/acqui/spent.pl >index 20d2b13c0c..ba843a8d72 100755 >--- a/acqui/spent.pl >+++ b/acqui/spent.pl >@@ -119,7 +119,7 @@ while ( my $data = $sth->fetchrow_hashref ) { > > my $total = $subtotal; > $query = qq{ >- SELECT invoicenumber, shipmentcost >+ SELECT invoiceid, invoicenumber, shipmentcost > FROM aqinvoices > WHERE shipmentcost_budgetid = ? > }; >@@ -129,7 +129,8 @@ my @shipmentcosts; > while (my $data = $sth->fetchrow_hashref) { > push @shipmentcosts, { > shipmentcost => sprintf("%.2f", $data->{shipmentcost}), >- invoicenumber => $data->{invoicenumber} >+ invoiceid => $data->{invoiceid}, >+ invoicenumber => $data->{invoicenumber} > }; > $total += $data->{shipmentcost}; > } >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt >index 2e5ca3f830..6466080799 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt >@@ -88,7 +88,7 @@ > <tr> > <td></td> > <td colspan="8">Shipping cost for invoice >- <a href="/cgi-bin/koha/acqui/invoice.pl?invoiceid=[% shipmentcode.invoiceid | uri %]"> >+ <a href="/cgi-bin/koha/acqui/invoice.pl?invoiceid=[% shipmentcost.invoiceid | uri %]"> > [% shipmentcost.invoicenumber | html %] > </a> > </td> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23363
:
91748
|
91749
| 91772 |
91773