From 224b5d441b567dfa969e9107ba363729dfe26701 Mon Sep 17 00:00:00 2001
From: Nick Clemens <nick@bywatersolutions.com>
Date: Wed, 21 Aug 2019 13:25:48 +0000
Subject: [PATCH] Bug 23485: Add barocde to holds to pull

This adds a barcode column, it tries to show 'Only' in the case of a single item, however, group by
problems here may mean that you see several items that will fill a next available hold on this record instead
of the single item to fill a patrons hold (i.e. the patron shown may not match the item list)

As the group by is a bigger problem, I don't think we should block this one by that

To test:
1 - Place an item level hold on a bib with several items with the same callnumber
2 - View the holds to pull report
3 - Try to guess which one on the shelf is right?
4 - Apply patch
5 - See the barcode in holds to pull report
6 - You can now grab the correct item (but don't yet)
7 - Place a next available hold on the same title
8 - See the report now lists all the barcodes on the item, but shows the borrower with a single hold
9 - Check in a different item that fills the next available hold
10 - Now the report shows the single item for the borrower
---
 circ/pendingreserves.pl                                     |  3 +++
 .../intranet-tmpl/prog/en/modules/circ/pendingreserves.tt   | 13 +++++++++++++
 2 files changed, 16 insertions(+)

diff --git a/circ/pendingreserves.pl b/circ/pendingreserves.pl
index 983bfdf41f..970705b1bd 100755
--- a/circ/pendingreserves.pl
+++ b/circ/pendingreserves.pl
@@ -197,6 +197,8 @@ my $strsth =
                     ORDER BY items.itemnumber SEPARATOR '|') l_enumchron,
             GROUP_CONCAT(DISTINCT items.copynumber
                     ORDER BY items.itemnumber SEPARATOR '|') l_copynumber,
+            GROUP_CONCAT(DISTINCT items.barcode
+                    ORDER BY items.itemnumber SEPARATOR '|') l_barcode,
             biblio.title,
             biblio.subtitle,
             biblio.medium,
@@ -259,6 +261,7 @@ while ( my $data = $sth->fetchrow_hashref ) {
             itemcallnumber  => [split('\|', $data->{l_itemcallnumber})],
             enumchron       => [split('\|', $data->{l_enumchron})],
             copyno          => [split('\|', $data->{l_copynumber})],
+            barcode         => [split('\|', $data->{l_barcode})],
             count           => $data->{icount},
             rcount          => $data->{rcount},
             pullcount       => $data->{icount} <= $data->{rcount} ? $data->{icount} : $data->{rcount},
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt
index 1510f81ed9..f672c8172d 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt
@@ -57,6 +57,7 @@
         <th>First patron</th>
         <th class="anti-the">Title</th>
         <th class="string-sort">Libraries</th>
+        <th>Available barcodes</th>
         <th>Available call numbers</th>
         <th>Available copy numbers</th>
         <th>Available enumeration</th>
@@ -100,6 +101,18 @@
             [% END %]
         </td>
         <td>
+            [% IF ( reserveloo.barcode ) %]
+            [% IF ( reserveloo.itemnumber ) %]Only[% END %]
+                <ul>
+                    [% FOREACH barcode IN reserveloo.barcode  %]
+                        <li>
+                            [% barcode | html %]
+                        </li>
+                    [% END %]
+                </ul>
+            [% END %]
+        </td>
+        <td>
             [% IF ( reserveloo.itemcallnumber ) %]
                 <ul>
                     [% FOREACH itemcallnumber IN reserveloo.itemcallnumber  %]
-- 
2.11.0