From fb856fef20a468c779cab56a8b647716745ad61d Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Mon, 9 Sep 2019 16:58:04 +0000 Subject: [PATCH] Bug 23575: Template error causes item search to be submitted multiple times This patch corrects the item search template so that the submit handler is not nested inside an unrelated loop. The change should have no outward effect on the behavior of the item search other than making it faster. To observe the bug in action, open your browser's developer tools and click the "Network" tab. Filter the output to only "XHR" and perform an item search. You should see multiple requests. To test, apply the patch and perform an item search. It should behave normally. Check the browser's "Network" monitor again to verify that only one request is being sent. --- .../intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt index a220e1c4f8b..7adecfe6ac2 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt @@ -457,15 +457,16 @@ } } }); - $('#itemsearchform').submit(function() { - var searchform = $(this); - var format = searchform.find('input[name="format"]:checked').val(); - if (format == 'html') { + }); + + $('#itemsearchform').submit(function() { + var searchform = $(this); + var format = searchform.find('input[name="format"]:checked').val(); + if (format == 'html') { submitForm(searchform); $("#item-search-block").hide(); return false; - } - }); + } }); }); -- 2.11.0