Bugzilla – Attachment 92771 Details for
Bug 22037
Regression: guarantor no longer blocked (debarred) if child is over limit, when checking out via SIP
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22037: (QA follow-up) Implement use of CHARGES_GUARANTEES
Bug-22037-QA-follow-up-Implement-use-of-CHARGESGUA.patch (text/plain), 1.28 KB, created by
Marcel de Rooy
on 2019-09-13 07:39:34 UTC
(
hide
)
Description:
Bug 22037: (QA follow-up) Implement use of CHARGES_GUARANTEES
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2019-09-13 07:39:34 UTC
Size:
1.28 KB
patch
obsolete
>From 1a2e36da270d88ae3e2d5f82cc854ae637b8d50e Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 22 Aug 2019 09:25:54 -0400 >Subject: [PATCH] Bug 22037: (QA follow-up) Implement use of CHARGES_GUARANTEES >Content-Type: text/plain; charset=utf-8 > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/SIP/ILS/Patron.pm | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/C4/SIP/ILS/Patron.pm b/C4/SIP/ILS/Patron.pm >index 080ab51607..96ec74ab81 100644 >--- a/C4/SIP/ILS/Patron.pm >+++ b/C4/SIP/ILS/Patron.pm >@@ -65,8 +65,12 @@ sub new { > $dob and $dob =~ s/-//g; # YYYYMMDD > my $dexpiry = $kp->{dateexpiry}; > $dexpiry and $dexpiry =~ s/-//g; # YYYYMMDD >+ > my $fines_amount = $flags->{CHARGES}->{amount}; # This "amount" is the negative balance or the one of the guarantees > $fines_amount = ($fines_amount and $fines_amount > 0) ? $fines_amount : 0; >+ my $guarantees_fines_amount = $flags->{CHARGES_GUARANTEES} ? $flags->{CHARGES_GUARANTEES}->{amount} : 0; >+ $fines_amount += $guarantees_fines_amount; >+ > my $fee_limit = _fee_limit(); > my $fine_blocked = $fines_amount > $fee_limit; > my $circ_blocked =( C4::Context->preference('OverduesBlockCirc') ne "noblock" && defined $flags->{ODUES}->{itemlist} ) ? 1 : 0; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22037
:
83436
|
91229
|
92434
|
92770
| 92771 |
92772