From 2aaa69e1de78ebc7aef080f478ed9be27f038f49 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Fri, 13 Sep 2019 15:04:15 +0100 Subject: [PATCH] Bug 23608: Update return value of Koha::Object::Limit::Library --- Koha/Object/Limit/Library.pm | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/Koha/Object/Limit/Library.pm b/Koha/Object/Limit/Library.pm index 7d86b94d63..341b674d3b 100644 --- a/Koha/Object/Limit/Library.pm +++ b/Koha/Object/Limit/Library.pm @@ -73,24 +73,23 @@ sub library_limits { my $limits = $object->get_library_limits(); Returns the current library limits in the form of a Koha::Libraries iterator object. -It returns undef if no library limits defined. +It returns a Koha::Libraries resultset containing all libraries if no library limits +are defined. =cut sub get_library_limits { my ($self) = @_; - my @branchcodes - = $self->_library_limit_rs->search( + my @branchcodes = $self->_library_limit_rs->search( { $self->_library_limits->{id} => $self->id } ) - ->get_column( $self->_library_limits->{library} )->all(); + ->get_column( $self->_library_limits->{library} )->all(); - return unless @branchcodes; + my $libraries = Koha::Libraries->new(); + return $libraries unless @branchcodes; my $filter = [ map { { branchcode => $_ } } @branchcodes ]; - my $libraries = Koha::Libraries->search( $filter ); - - return $libraries; + return $libraries->search($filter); } =head3 add_library_limit -- 2.20.1