Bugzilla – Attachment 9283 Details for
Bug 7189
preference to control if returning lost items gives refund
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7189 - preference to control if returning lost items gives refund
Bug-7189---preference-to-control-if-returning-lost.patch (text/plain), 3.42 KB, created by
Kyle M Hall
on 2012-04-24 13:08:27 UTC
(
hide
)
Description:
Bug 7189 - preference to control if returning lost items gives refund
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2012-04-24 13:08:27 UTC
Size:
3.42 KB
patch
obsolete
>From c2a71dcb9c4b7fdb464237ccde320fdd8c1c2acf Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 24 Apr 2012 09:05:36 -0400 >Subject: [PATCH] Bug 7189 - preference to control if returning lost items gives refund > >Right now when you return an item that was lost the patron's card is >credited with the lost fee, but not all libraries refund lost fees >and sometimes the fee is refunded after the patron has paid for it, >causing all kinds of financial issues. > >Adds the syspref RefundLostItemFeeOnReturn to control whether >returning a lost item refunds the fee charged for losing that >item. Enabled by default to maintain Koha's current functionality. >--- > C4/Circulation.pm | 4 +++- > installer/data/mysql/sysprefs.sql | 1 + > installer/data/mysql/updatedatabase.pl | 7 +++++++ > 3 files changed, 11 insertions(+), 1 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index b7e08f2..ad6cf51 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -1062,7 +1062,9 @@ sub AddIssue { > > ## If item was lost, it has now been found, reverse any list item charges if neccessary. > if ( $item->{'itemlost'} ) { >- _FixAccountForLostAndReturned( $item->{'itemnumber'}, undef, $item->{'barcode'} ); >+ if ( C4::Context->preference('RefundLostItemFeeOnReturn' ) { >+ _FixAccountForLostAndReturned( $item->{'itemnumber'}, undef, $item->{'barcode'} ); >+ } > } > > ModItem({ issues => $item->{'issues'}, >diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql >index 49debd2..38b6258 100644 >--- a/installer/data/mysql/sysprefs.sql >+++ b/installer/data/mysql/sysprefs.sql >@@ -362,3 +362,4 @@ INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES(' > INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES ('AutoResumeSuspendedHolds', '1', NULL , 'Allow suspended holds to be automatically resumed by a set date.', 'YesNo'); > INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES ('OpacStarRatings','all',NULL,'disable|all|details','Choice'); > INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('OpacBrowseResults','1','Disable/enable browsing and paging search results from the OPAC detail page.',NULL,'YesNo'); >+INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('RefundLostItemFeeOnReturn', '1', 'If enabled, the lost item fee charged to a borrower will be refunded when the lst item is returned.', NULL, 'YesNo'); >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index 84f0437..e242856 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -5212,6 +5212,13 @@ if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) { > SetVersion($DBversion); > } > >+$DBversion = "3.08.00.XXX"; >+if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) { >+ $dbh->do("INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('RefundLostItemFeeOnReturn', '1', 'If enabled, the lost item fee charged to a borrower will be refunded when the lst item is returned.', NULL, 'YesNo')"); >+ print "Upgrade to $DBversion done ( Add system preference RefundLostItemFeeOnReturn )\n"; >+ SetVersion($DBversion); >+} >+ > =head1 FUNCTIONS > > =head2 TableExists($table) >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7189
:
9283
|
10614
|
10892
|
10951
|
10971
|
10974
|
11005
|
11054