Bugzilla – Attachment 93115 Details for
Bug 22744
Remove confusing 'Do not notify' checkboxes from messaging preferences
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22744: Changes for opac and remove JS
Bug-22744-Changes-for-opac-and-remove-JS.patch (text/plain), 4.95 KB, created by
Nick Clemens
on 2019-09-23 10:25:57 UTC
(
hide
)
Description:
Bug 22744: Changes for opac and remove JS
Filename:
MIME Type:
Creator:
Nick Clemens
Created:
2019-09-23 10:25:57 UTC
Size:
4.95 KB
patch
obsolete
>From ee5be0cc4ac21851d4e3e934dcbbaf47cb35ade0 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 23 Sep 2019 10:25:13 +0000 >Subject: [PATCH] Bug 22744: Changes for opac and remove JS > >--- > .../intranet-tmpl/prog/js/messaging-preference-form.js | 18 ------------------ > .../opac-tmpl/bootstrap/en/modules/opac-messaging.tt | 6 ++---- > 2 files changed, 2 insertions(+), 22 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/messaging-preference-form.js b/koha-tmpl/intranet-tmpl/prog/js/messaging-preference-form.js >index 93f1ce3fbb..ea01a62d80 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/messaging-preference-form.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/messaging-preference-form.js >@@ -1,21 +1,4 @@ > $(document).ready(function(){ >- $(".none").click(function(){ >- if($(this).prop("checked")){ >- var rowid = $(this).attr("id"); >- var newid = Number(rowid.replace("none","")); >- $("#sms"+newid).prop("checked", false); >- $("#email"+newid).prop("checked", false); >- $("#phone"+newid).prop("checked", false); >- $("#digest"+newid).prop("checked", false); >- $("#rss"+newid).prop("checked", false); >- } >- }); >- $(".active_notify").on("change",function(){ >- var attr_id = $(this).data("attr-id"); >- if( $(this).prop("checked") ){ >- $("#none" + attr_id ).prop("checked", false); >- } >- }); > $("#info_digests").tooltip(); > > var message_prefs_dirty = false; >@@ -36,7 +19,6 @@ $(document).ready(function(){ > return; > } > } >- $(".none").prop("checked", false); // When loading default prefs the "Do not notify" boxes should be cleared > var jqxhr = $.getJSON('/cgi-bin/koha/members/default_messageprefs.pl?categorycode=' + categorycode, function(data) { > $.each(data.messaging_preferences, function(i, item) { > var attrid = item.message_attribute_id; >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt >index fdd5571580..d33c7b7b88 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt >@@ -40,7 +40,6 @@ > [% IF ( TalkingTechItivaPhone ) %]<th>Phone</th>[% END %] > <th>Email</th> > <th>Digests only <i id="info_digests" data-toggle="tooltip" title="You can ask for a digest to reduce the number of messages. Messages will be saved and sent as a single message." data-placement="right" class="fa fa-info-circle"></i></th> >- <!-- <th>RSS</th> --><th>Do not notify</th> > </tr> > </thead> > <tbody> >@@ -70,9 +69,9 @@ > [% IF ( messaging_preference.transport_sms ) %] > <td> > [% IF ( messaging_preference.transports_sms ) %] >- <input type="checkbox" id="sms[% messaging_preference.message_attribute_id | html %]" name="[% messaging_preference.message_attribute_id | html %]" value="sms" checked="checked" onclick = "document.opacmessaging.none[% messaging_preference.message_attribute_id | html %].checked=false;" /> >+ <input type="checkbox" id="sms[% messaging_preference.message_attribute_id | html %]" name="[% messaging_preference.message_attribute_id | html %]" value="sms" checked="checked" /> > [% ELSE %] >- <input type="checkbox" id="sms[% messaging_preference.message_attribute_id | html %]" name="[% messaging_preference.message_attribute_id | html %]" value="sms" onclick = "document.opacmessaging.none[% messaging_preference.message_attribute_id | html %].checked=false;" /> >+ <input type="checkbox" id="sms[% messaging_preference.message_attribute_id | html %]" name="[% messaging_preference.message_attribute_id | html %]" value="sms" /> > [% END %] > </td> > [% ELSE %] >@@ -123,7 +122,6 @@ > <td>-</td> > [% END %] > >- <td><input type="checkbox" class="none" id="none[% messaging_preference.message_attribute_id | html %]" /></td> > </tr> > [% END # / FOREACH messaging_preferences%] > </tbody> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22744
:
88357
|
88534
|
88535
|
90454
|
90568
|
90569
|
90570
|
90571
|
90572
|
90574
|
92642
|
92643
|
92644
|
92645
|
92646
|
92647
|
93109
|
93114
| 93115