From 41784a0428c3969634c6201f16fff33165b5b51e Mon Sep 17 00:00:00 2001
From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Date: Thu, 10 Oct 2019 09:08:55 +0100
Subject: [PATCH] Bug 23049: Filter out system types by default
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Test Plan
1) Navigate to the debit types management page added in previous patches
2) Note that system types are now filtered out by default
3) Click on the new unfilter button to include system types
4) Signoff

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
---
 .../prog/en/modules/admin/debit_types.tt      | 26 +++++++++++++++++--
 1 file changed, 24 insertions(+), 2 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/debit_types.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/debit_types.tt
index 986e57d5c7..f9f575c9bb 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/debit_types.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/debit_types.tt
@@ -153,6 +153,7 @@
                     [% IF debit_types.count %]
                         <table id="table_debit_types">
                             <thead>
+                                <th>System</th>
                                 <th>Code</th>
                                 <th>Description</th>
                                 <th>Default amount</th>
@@ -163,6 +164,7 @@
                             <tbody>
                                 [% FOREACH debit_type IN debit_types %]
                                 <tr>
+                                    <td>[% debit_type.is_system | html %]</td>
                                     <td>[% debit_type.code | html %]</td>
                                     <td>[% debit_type.description | html %]</td>
                                     <td>[% debit_type.default_amount | $Price %]</td>
@@ -219,14 +221,34 @@
 
     <script>
         $(document).ready(function() {
-            $("#table_debit_types").dataTable($.extend(true, {}, dataTablesDefaults, {
+            var txtActivefilter = _("Filter system debit types");
+            var txtInactivefilter = _("Show all debit types");
+            var table_debit_types = $("#table_debit_types").dataTable($.extend(true, {}, dataTablesDefaults, {
                 "aoColumnDefs": [
                     { "aTargets": [ -1 ], "bSortable": false, "bSearchable": false },
+                    { "aTargets": [ 0 ], "bSortable": false, "bVisible": false },
                 ],
                 "aaSorting": [[ 1, "asc" ]],
-                "iDisplayLength": 10,
+                "sDom": 'C<"top pager"ilpfB><"#filter_s">tr<"bottom pager"ip>',
+                "iDisplayLength": 20,
                 "sPaginationType": "full_numbers"
             }));
+            $("#filter_s").html('<p><a href="#" id="filter_system"><i class="fa fa-filter"></i> '+txtActivefilter+'</a>');
+            $('#filter_system').click(function(e) {
+                e.preventDefault();
+                if ($(this).hasClass('filtered')) {
+                    var filteredValue = '';
+                    $(this).html('<i class="fa fa-filter"></i> '+txtActivefilter);
+                } else { //Not filtered. Let's do it!
+                    var filteredValue = '0';
+                    $(this).html('<i class="fa fa-filter"></i> '+txtInactivefilter);
+                }
+                table_debit_types.fnFilter(filteredValue, 0, false, false);
+                $(this).toggleClass('filtered');
+            });
+
+            //Start filtered
+            $('#filter_system').click();
         });
     </script>
 [% END %]
-- 
2.20.1