Bugzilla – Attachment 94401 Details for
Bug 23825
Object.t is failing - Exception not caught
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23825: Koha/Object.t might fail on a backtick
Bug-23825-KohaObjectt-might-fail-on-a-backtick.patch (text/plain), 1.47 KB, created by
Marcel de Rooy
on 2019-10-18 09:34:25 UTC
(
hide
)
Description:
Bug 23825: Koha/Object.t might fail on a backtick
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2019-10-18 09:34:25 UTC
Size:
1.47 KB
patch
obsolete
>From ac6d3358785d3bb84901353d754040454d27b04f Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 18 Oct 2019 09:31:10 +0000 >Subject: [PATCH] Bug 23825: Koha/Object.t might fail on a backtick >Content-Type: text/plain; charset=utf-8 > >If the SQL error message contains a backtick instead of a regular quote, >the regex for throwing an exception did not work. >Example: >Incorrect datetime value: 'wrong_value' for column `koha_master`.`borrowers`.`lastseen` >Note the backtics where the regex contains a regular quote. > >This patch makes it more flexible: it allows one \W character before the >column name, even optional. > >Test plan: >Run Koha/Object.t > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > Koha/Object.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/Koha/Object.pm b/Koha/Object.pm >index 108ea2e52f..bec4a18eaa 100644 >--- a/Koha/Object.pm >+++ b/Koha/Object.pm >@@ -174,7 +174,8 @@ sub store { > duplicate_id => $+{key} > ); > } >- elsif( $_->{msg} =~ /Incorrect (?<type>\w+) value: '(?<value>.*)' for column '(?<property>\w+)'/ ) { >+ elsif( $_->{msg} =~ /Incorrect (?<type>\w+) value: '(?<value>.*)' for column \W?(?<property>\w+)/ ) { >+ # The optional \W in the regex might be a quote or backtick > Koha::Exceptions::Object::BadValue->throw( > type => $+{type}, > value => $+{value}, >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23825
:
94401
|
94654
|
94661
|
94662
|
94803
|
94804
|
95044
|
95053
|
95402
|
95403
|
95404
|
95405