From 2663428674782871cdf70c44c4f1407a0c9567e0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi>
Date: Tue, 22 Oct 2019 12:39:35 +0000
Subject: [PATCH] Bug 18795: (follow-up) Check whether patrons exists before
 deleting history

Running $patrons->anonymise_issue_history after checking patrons
exists is more logical even though $patrons->anonymise_issue_history()
can handle 0 patrons returned in the search. Also this way we don't
have to run anonymise_issue_history() code unless needed, thus making
the code finish faster.
---
 Koha/REST/V1/Checkouts.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Koha/REST/V1/Checkouts.pm b/Koha/REST/V1/Checkouts.pm
index ba3c615a2a..887714d22c 100644
--- a/Koha/REST/V1/Checkouts.pm
+++ b/Koha/REST/V1/Checkouts.pm
@@ -197,14 +197,14 @@ sub delete_history {
         'me.borrowernumber' => $patron_id
     });
 
-    $patrons->anonymise_issue_history;
-
     unless ($patrons->count) {
         return $c->render( status => 404, openapi => {
             error => "Patron doesn't exist"
         });
     }
 
+    $patrons->anonymise_issue_history;
+
     return $c->render( status => 204, openapi => "" );
 }
 
-- 
2.17.1