From 0d7b943da8315fd797318f0761628b146f49e982 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Sun, 3 Nov 2019 22:03:46 +0000
Subject: [PATCH] Bug 23955: Replace famfamfam icon in OPAC holds template

This patch modifies the OPAC holds template so that when an item isn't
available for an item-level hold a Font Awesome icon is displayed
instead of a famfamfam image.

To test, apply the patch and regenerate the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

 - Make sure you have items which can be placed on hold at the item
   level.
 - Locate a title with more than one item, at least one of which isn't
   available to be placed on hold (item is marked withdrawn, for
   instance).
 - Start the process of placing a hold on the item.
 - On the "Confirm holds" scren, click "Show more options" and select "A
   specific item."
 - In the table of items, any item which isn't available to be put on
   hold should be inidicated with a red X. The title attribute of the
   icon should show "Cannot be put on hold."
---
 koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss          | 4 ++++
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
index b9d70b13f4..9e481e624d 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
@@ -38,6 +38,10 @@ $footer-height: 45px;
     &.fa-icon-white {
         color: #000;
     }
+
+    &.danger {
+        color: #C00;
+    }
 }
 
 .popup {
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
index 64263ef9a3..17fca3c1e2 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
@@ -354,7 +354,7 @@
                                                                 [% ELSE %]
                                                                     <input disabled="disabled" type="radio" class="checkitem" name="checkitem" value="[% itemLoo.itemnumber | html %]"
                                                                            style="display:none;" />
-                                                                    <img src="[% interface | html %]/lib/famfamfam/cross.png" alt="Cannot be put on hold" title="Cannot be put on hold" />
+                                                                    <i class="fa fa-remove danger" title="Cannot be put on hold"></i>
                                                                 [% END %]
 
                                                                 [% IF ( itemLoo.copynumber ) %]
-- 
2.11.0