From a2ab223ae0e7c2fa32e9c809a5e243ee688d02be Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 11 Nov 2019 09:42:42 +0100 Subject: [PATCH] Bug 23964: Use is instead of isnt in tests --- t/db_dependent/Reserves.t | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t index e362f11adc..92c9068738 100755 --- a/t/db_dependent/Reserves.t +++ b/t/db_dependent/Reserves.t @@ -709,13 +709,13 @@ subtest 'ReservesNeedReturns' => sub { $item->onloan('2010-01-01')->store; $hold = place_item_hold( $patron, $item, $library, $priority ); - isnt( $hold->priority, 0, 'If ReservesNeedReturns is 0 but item onloan priority must not be set to 0' ); + is( $hold->priority, 1, 'If ReservesNeedReturns is 0 but item onloan priority must be set to 1' ); $hold->delete; t::lib::Mocks::mock_preference('AllowHoldsOnDamagedItems', 0); # '0' means damaged holds not allowed $item->onloan(undef)->damaged(1)->store; $hold = place_item_hold( $patron, $item, $library, $priority ); - isnt( $hold->priority, 0, 'If ReservesNeedReturns is 0 but item damaged and not allowed holds on damaged items priority must not be set to 0' ); + is( $hold->priority, 1, 'If ReservesNeedReturns is 0 but item damaged and not allowed holds on damaged items priority must be set to 1' ); $hold->delete; t::lib::Mocks::mock_preference('AllowHoldsOnDamagedItems', 1); # '0' means damaged holds not allowed $hold = place_item_hold( $patron, $item, $library, $priority ); @@ -724,11 +724,10 @@ subtest 'ReservesNeedReturns' => sub { my $hold_1 = place_item_hold( $patron, $item, $library, $priority ); $hold = place_item_hold( $patron_2, $item, $library, $priority ); - isnt( $hold->priority, 0, 'If ReservesNeedReturns is 0 but item already on hold priority must not be set to 0' ); + is( $hold->priority, 1, 'If ReservesNeedReturns is 0 but item already on hold priority must be set to 1' ); $hold->delete; $hold_1->delete; - $hold->delete; $builder->build({ source => "Branchtransfer", value => { itemnumber => $item->itemnumber, datearrived => undef, -- 2.11.0