Bugzilla – Attachment 95249 Details for
Bug 23964
An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23964: Use is instead of isnt in tests
Bug-23964-Use-is-instead-of-isnt-in-tests.patch (text/plain), 2.21 KB, created by
Jonathan Druart
on 2019-11-11 08:43:00 UTC
(
hide
)
Description:
Bug 23964: Use is instead of isnt in tests
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2019-11-11 08:43:00 UTC
Size:
2.21 KB
patch
obsolete
>From a2ab223ae0e7c2fa32e9c809a5e243ee688d02be Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 11 Nov 2019 09:42:42 +0100 >Subject: [PATCH] Bug 23964: Use is instead of isnt in tests > >--- > t/db_dependent/Reserves.t | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > >diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t >index e362f11adc..92c9068738 100755 >--- a/t/db_dependent/Reserves.t >+++ b/t/db_dependent/Reserves.t >@@ -709,13 +709,13 @@ subtest 'ReservesNeedReturns' => sub { > > $item->onloan('2010-01-01')->store; > $hold = place_item_hold( $patron, $item, $library, $priority ); >- isnt( $hold->priority, 0, 'If ReservesNeedReturns is 0 but item onloan priority must not be set to 0' ); >+ is( $hold->priority, 1, 'If ReservesNeedReturns is 0 but item onloan priority must be set to 1' ); > $hold->delete; > > t::lib::Mocks::mock_preference('AllowHoldsOnDamagedItems', 0); # '0' means damaged holds not allowed > $item->onloan(undef)->damaged(1)->store; > $hold = place_item_hold( $patron, $item, $library, $priority ); >- isnt( $hold->priority, 0, 'If ReservesNeedReturns is 0 but item damaged and not allowed holds on damaged items priority must not be set to 0' ); >+ is( $hold->priority, 1, 'If ReservesNeedReturns is 0 but item damaged and not allowed holds on damaged items priority must be set to 1' ); > $hold->delete; > t::lib::Mocks::mock_preference('AllowHoldsOnDamagedItems', 1); # '0' means damaged holds not allowed > $hold = place_item_hold( $patron, $item, $library, $priority ); >@@ -724,11 +724,10 @@ subtest 'ReservesNeedReturns' => sub { > > my $hold_1 = place_item_hold( $patron, $item, $library, $priority ); > $hold = place_item_hold( $patron_2, $item, $library, $priority ); >- isnt( $hold->priority, 0, 'If ReservesNeedReturns is 0 but item already on hold priority must not be set to 0' ); >+ is( $hold->priority, 1, 'If ReservesNeedReturns is 0 but item already on hold priority must be set to 1' ); > $hold->delete; > $hold_1->delete; > >- $hold->delete; > $builder->build({ source => "Branchtransfer", value => { > itemnumber => $item->itemnumber, > datearrived => undef, >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23964
:
95016
|
95017
|
95021
|
95022
|
95111
|
95249
|
95544
|
95594
|
95595
|
95596
|
95597
|
95598
|
95599
|
95639
|
95640
|
95641
|
95642
|
95643
|
95644
|
95780
|
95781