Bugzilla – Attachment 95397 Details for
Bug 23854
Cannot edit a suggestion
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23854: Fix failure on dates when editing a suggestion
Bug-23854-Fix-failure-on-dates-when-editing-a-sugg.patch (text/plain), 1.43 KB, created by
Katrin Fischer
on 2019-11-13 14:45:21 UTC
(
hide
)
Description:
Bug 23854: Fix failure on dates when editing a suggestion
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2019-11-13 14:45:21 UTC
Size:
1.43 KB
patch
obsolete
>From a2488ee3c127ccb50f6ab422caa88f6ed4433fa9 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 22 Oct 2019 11:10:59 +0200 >Subject: [PATCH] Bug 23854: Fix failure on dates when editing a suggestion > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> > >- Watch plack-error-log >- Change an accepted suggestion to 'No Status' >- Verify error in the logs (use strict mode, depending on DBMS version) >- Status changed was not saved >- Apply patch >- Verify the error is gone, change is saved now. >--- > suggestion/suggestion.pl | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > >diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl >index e1fca2611e..ef153ba88b 100755 >--- a/suggestion/suggestion.pl >+++ b/suggestion/suggestion.pl >@@ -123,8 +123,11 @@ my $branchfilter = $input->param('branchcode') || C4::Context->userenv->{'branch > ## Operations > ## > if ( $op =~ /save/i ) { >- $suggestion_only->{suggesteddate} = dt_from_string( $suggestion_only->{suggesteddate} ) >- if $suggestion_only->{suggesteddate}; >+ >+ for my $date_key ( qw( suggesteddate manageddate accepteddate rejecteddate ) ) { >+ $suggestion_only->{$date_key} = dt_from_string( $suggestion_only->{$date_key} ) >+ if $suggestion_only->{$date_key}; >+ } > > if ( $suggestion_only->{"STATUS"} ) { > if ( my $tmpstatus = lc( $suggestion_only->{"STATUS"} ) =~ /ACCEPTED|REJECTED/i ) { >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23854
:
94518
|
95316
|
95397
|
95409