From 0fc61d58f45b1eeda980bc82bd35de59cee0aba6 Mon Sep 17 00:00:00 2001
From: Maryse Simard <maryse.simard@inlibro.com>
Date: Mon, 18 Nov 2019 08:50:52 -0500
Subject: [PATCH] Bug 24046: Untranslatable 'Activate filters'

Bug 9573 moved the code for the table filters activation to it's
own javascript file. The strings contained in this file are not
translatable. This patch moves the strings to their own strings
file which is then included with the javascript from the templates.

Test plan:
Visit the catalogue/detail.pl and reports/itemslost.pl and test
that the 'Activate/Deactivate filters' option still work correctly.
---
 koha-tmpl/intranet-tmpl/prog/en/includes/str/table_filters.inc | 4 ++++
 koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt    | 1 +
 koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt   | 1 +
 koha-tmpl/intranet-tmpl/prog/js/table_filters.js               | 4 ++--
 4 files changed, 8 insertions(+), 2 deletions(-)
 create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/str/table_filters.inc

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/str/table_filters.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/str/table_filters.inc
new file mode 100644
index 0000000..5da6bcb
--- /dev/null
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/str/table_filters.inc
@@ -0,0 +1,4 @@
+<script>
+    var MSG_DEACTIVATE_FILTERS = _("Deactivate filters");
+    var MSG_ACTIVATE_FILTERS = _("Activate filters");
+</script>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
index 571f3b2..a1464af 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
@@ -1000,6 +1000,7 @@
     [% INCLUDE 'browser-strings.inc' %]
     [% INCLUDE 'columns_settings.inc' %]
     [% Asset.js("js/browser.js") | $raw %]
+    [% INCLUDE 'str/table_filters.inc' %]
     [% Asset.js("js/table_filters.js") | $raw %]
     <script>
         var browser;
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt
index 0b2dc2e..3f4baf7 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt
@@ -190,6 +190,7 @@
     [% INCLUDE 'datatables.inc' %]
     [% Asset.js("lib/jquery/plugins/jquery.dataTables.columnFilter.js") | $raw %]
     [% INCLUDE 'columns_settings.inc' %]
+    [% INCLUDE 'str/table_filters.inc' %]
     [% Asset.js("js/table_filters.js") | $raw %]
     [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %]
     <script>
diff --git a/koha-tmpl/intranet-tmpl/prog/js/table_filters.js b/koha-tmpl/intranet-tmpl/prog/js/table_filters.js
index 6607120..d7c4dc8 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/table_filters.js
+++ b/koha-tmpl/intranet-tmpl/prog/js/table_filters.js
@@ -23,7 +23,7 @@ function activate_filters(id) {
     }
 
     $('#' + id + '_activate_filters')
-        .html('<i class="fa fa-filter"></i> ' + _("Deactivate filters") )
+        .html('<i class="fa fa-filter"></i> ' + MSG_DEACTIVATE_FILTERS )
         .unbind('click')
         .click(function() {
             deactivate_filters(id);
@@ -41,7 +41,7 @@ function deactivate_filters(id) {
     filters_row.hide();
 
     $('#' + id + '_activate_filters')
-        .html('<i class="fa fa-filter"></i> ' + _("Activate filters") )
+        .html('<i class="fa fa-filter"></i> ' + MSG_ACTIVATE_FILTERS )
         .unbind('click')
         .click(function() {
             activate_filters(id);
-- 
2.7.4