From 0ec693a4962c0eed81994ffdab01cbc12163144c Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Tue, 19 Nov 2019 17:35:09 +0100
Subject: [PATCH] Bug 23591: Hide archived suggestions
However we are adding a note on top of the table to tell how many
suggestions are archived. It seems that there is no good reason to
display the archived suggestions on this table.
---
catalogue/detail.pl | 4 +++-
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 5 ++++-
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/catalogue/detail.pl b/catalogue/detail.pl
index d36a704607..819e4877bb 100755
--- a/catalogue/detail.pl
+++ b/catalogue/detail.pl
@@ -243,12 +243,14 @@ if ( C4::Context->preference('suggestion') ) {
my $suggestions = Koha::Suggestions->search(
{
biblionumber => $biblionumber,
+ archived => 0,
},
{
order_by => { -desc => 'suggesteddate' }
}
);
- $template->param( suggestions => $suggestions );
+ my $nb_archived_suggestions = Koha::Suggestions->search({ biblionumber => $biblionumber, archived => 1 })->count;
+ $template->param( suggestions => $suggestions, nb_archived_suggestions => $nb_archived_suggestions );
}
if ( defined $dat->{'itemtype'} ) {
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
index dc40ee5a7c..6b69cb7922 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
@@ -6,6 +6,7 @@
[% USE Branches %]
[% USE Biblio %]
[% USE ColumnsSettings %]
+[% PROCESS 'i18n.inc' %]
[% SET AdlibrisEnabled = Koha.Preference('AdlibrisCoversEnabled') %]
[% SET AdlibrisURL = Koha.Preference('AdlibrisCoversURL') %]
@@ -669,6 +670,9 @@
[% IF suggestions.count %]
<div id="suggestion_details">
+ [% IF nb_archived_suggestions > 0 %]
+ <p>[% tnpx('pluralization', 'There is one archived suggestion.', 'There are {count} archived suggestions.', nb_archived_suggestions, { count = nb_archived_suggestions }) | $raw %]
+ [% END %]
<table id="suggestions" class="sorted">
<thead>
<tr>
@@ -693,7 +697,6 @@
[% IF ( suggestion.copyrightdate ) %]© [% suggestion.copyrightdate | html %] [% END %]
[% IF ( suggestion.volumedesc ) %]; Volume:<i>[% suggestion.volumedesc | html %]</i> [% END %]
[% IF ( suggestion.isbn ) %]; ISBN:<i>[% suggestion.isbn | html %]</i> [% END %][% IF ( suggestion.publishercode ) %]; Published by [% suggestion.publishercode | html %] [% END %][% IF ( suggestion.publicationyear ) %] in <i>[% suggestion.publicationyear | html %]</i> [% END %][% IF ( suggestion.place ) %] in <i>[% suggestion.place | html %]</i> [% END %][% IF ( suggestion.collectiontitle ) %]; [% suggestion.collectiontitle | html %] [% END %][% IF ( suggestion.itemtype ) %]; [% AuthorisedValues.GetByCode( 'SUGGEST_FORMAT', suggestion.itemtype, 0 ) | html %] [% END %]<br />[% IF ( suggestion.note ) %]<div class="suggestion_note"><i class="fa fa-comment"></i> [% suggestion.note | html %]</div>[% END %]
- [% IF suggestion.archived %]<br /><i class="fa fa-archive"> Archived[% END %]
</td>
<td>
<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% suggestion.suggestedby | uri %]">[% INCLUDE 'patron-title.inc' patron => suggestion.suggester %]</a>
--
2.11.0