From 2bcebc82da5de7e9970b94bd9e75b3fe1b0ccb96 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Wed, 21 Aug 2019 02:24:11 +0000 Subject: [PATCH] Bug 23482: Fix BakerTaylor cover images on lists While this needs a username/pass to fully test, it should be possible to verify the code changes by comparing to opac-results code To test: 1 - Enable BakerTaylor images 2 - Enter your usernme and password 3 - Do not fill the BookStore URL 4 - Verify OPAC covers are working 5 - Save some times with covers to a public list 6 - Verify they do not display in list 7 - Apply patch 8 - Verify images now work Signed-off-by: Kelly McElligott --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 15 +++++++++++++-- opac/opac-shelves.pl | 14 ++++++++++++++ 2 files changed, 27 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt index c1d273f66e..cc5f75c5b1 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt @@ -352,10 +352,21 @@ [% END %] - [% IF ( BakerTaylorEnabled ) %] + [% IF ( Koha.Preference('BakerTaylorEnabled') && !Koha.Preference('BakerTaylorBookstoreURL') ) %] [% bt_id = ( itemsloo.normalized_upc || itemsloo.normalized_isbn ) %] [% IF ( bt_id ) %] - See Baker & Taylor + See Baker & Taylor + [% ELSE %] + No cover image available + [% END %] + [% END %] + + [% IF ( Koha.Preference('BakerTaylorEnabled') && Koha.Preference('BakerTaylorBookstoreURL') ) %] + [% bt_id = ( itemsloo.normalized_upc || itemsloo.normalized_isbn ) %] + [% IF ( bt_id ) %] + + See Baker & Taylor + [% ELSE %] No cover image available [% END %] diff --git a/opac/opac-shelves.pl b/opac/opac-shelves.pl index 802366d994..f51044b626 100755 --- a/opac/opac-shelves.pl +++ b/opac/opac-shelves.pl @@ -40,6 +40,13 @@ use Koha::RecordProcessor; use constant ANYONE => 2; +BEGIN { + if (C4::Context->preference('BakerTaylorEnabled')) { + require C4::External::BakerTaylor; + import C4::External::BakerTaylor qw(&image_url &link_url); + } +} + my $query = new CGI; my $template_name = $query->param('rss') ? "opac-shelves-rss.tt" : "opac-shelves.tt"; @@ -57,6 +64,13 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user({ authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ), }); +if (C4::Context->preference("BakerTaylorEnabled")) { + $template->param( + BakerTaylorImageURL => &image_url(), + BakerTaylorLinkURL => &link_url(), + ); +} + my $op = $query->param('op') || 'list'; my $referer = $query->param('referer') || $op; my $category = $query->param('category') || 1; -- 2.11.0