Bugzilla – Attachment 95746 Details for
Bug 23958
Use Font Awesome icon to replace "new window" icon image
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23958: Use Font Awesome icon to replace "new window" icon image
Bug-23958-Use-Font-Awesome-icon-to-replace-new-win.patch (text/plain), 10.50 KB, created by
Katrin Fischer
on 2019-11-22 21:17:53 UTC
(
hide
)
Description:
Bug 23958: Use Font Awesome icon to replace "new window" icon image
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2019-11-22 21:17:53 UTC
Size:
10.50 KB
patch
obsolete
>From 225b04594b9304134fc55f3bc14f208f72eaa283 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Sun, 3 Nov 2019 19:38:20 -0500 >Subject: [PATCH] Bug 23958: Use Font Awesome icon to replace "new window" icon > image > >This patch modifies several templates in order to eliminate the >dependency on an image file for styling certain links which open popups >or new windows. A Font Awesome icon is used instead. > >To test, apply the patch and rebuild the staff client CSS >(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). > >Cataloging: > > - Create a new MARC record which has the same ISBN as a record in your > catalog. > - When you save the record it should warn you that it is a possible > duplicate. The message should contain an icon-prefixed link to the > existing record. > - Clicking the link should open details about the title in a new > window. > >Circulation: > > - Enable the itemBarcodeFallbackSearch system preference. > - Open a patron for checkout and enter a word in the "barcode" field > instead of a barcode. > - The page should return a list of titles to choose from. Each title > should be a link with an icon. Clicking the link should open details > about the title in a new window. > >Acquisitions: > > - Go to Acquistisions -> Vendor -> Basket. > - Choose "Add to basket" -> From an external source. > - Search for and select a record which exists in your catalog. > - You should be taken to a page with a "Duplicate warning" message. The > message should contain an icon-prefixed link to the existing record. > - Clicking this link should open details about the title in a new > window. > > - Create a MARC file with two records: One which exists in your catalog > and one which doesn't. Stage that file for import. > - Choose "Add to basket" again and select "From a staged file." > - Select the file you staged. > - You should be taken to a page with a "Duplicate warning" message. The > message should contain an icon-prefixed link to the existing record. > - Clicking the link should open details about the title in a new > window. > >Patrons: > > - Create a new patron which has the same name and birthday as an > existing patron. > - When you save the record you should be shown a duplicate warning. The > link to the possible duplicate patron should be prefixed with an icon > and should open the patron's details in a popup window. > >Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 5 ----- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt | 2 +- > .../prog/en/modules/acqui/neworderempty_duplicate.tt | 8 ++++---- > koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 2 +- > 6 files changed, 8 insertions(+), 13 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >index 2ffaef1a78..950da22f35 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >@@ -73,11 +73,6 @@ a { > color: #666; > } > >- &.popup { >- background: transparent url("../img/pop-up-link.png") center right no-repeat; >- padding-right: 15px; >- } >- > &.disabled { > color: #999999; > } >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >index c3d61a0f35..7947dba987 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >@@ -386,7 +386,7 @@ > [% END %] > [% IF ( duplinbatch ) %]<div class="dialog alert"> > <h4>Duplicate warning</h4> >- <p>Some records have not been automatically added because they match an existing record in your catalog:<a href="/cgi-bin/koha/acqui/addorderiso2709.pl?import_batch_id=[% duplinbatch | uri %]&basketno=[% basketno | uri %]&booksellerid=[% booksellerid | uri %]" title="Open in new window" target="_blank" class="popup" style="margin-left:10px">Display them</a></p> >+ <p>Some records have not been automatically added because they match an existing record in your catalog:<a href="/cgi-bin/koha/acqui/addorderiso2709.pl?import_batch_id=[% duplinbatch | uri %]&basketno=[% basketno | uri %]&booksellerid=[% booksellerid | uri %]" title="Open in new window" target="_blank" style="margin-left:10px"><i class="fa fa-window-restore"></i> Display them</a></p> > </div>[% END %] > > <div id="acqui_basket_content"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty_duplicate.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty_duplicate.tt >index 8c5b8a4aac..b59c05da86 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty_duplicate.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty_duplicate.tt >@@ -16,10 +16,10 @@ > > <div class="dialog alert"> > <h4>Duplicate warning</h4> >-<p>You selected a record from an external source that matches an existing record in your catalog: [% IF ( BiblioDefaultViewmarc ) %]<a class="popup" target="_blank" title="Open in new window" href="/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=[% biblionumber |url %]"> >-[% ELSIF ( BiblioDefaultViewlabeled_marc ) %]<a class="popup" target="_blank" title="Open in new window" href="/cgi-bin/koha/catalogue/labeledMARCdetail.pl?biblionumber=[% biblionumber |url %]"> >-[% ELSIF ( BiblioDefaultViewisbd ) %]<a class="popup" target="_blank" title="Open in new window" href="/cgi-bin/koha/catalogue/ISBDdetail.pl?biblionumber=[% biblionumber |url %]"> >-[% ELSE %]<a class="popup" target="_blank" title="Open in new window" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% biblionumber |url %]">[% END %][% duplicatetitle | html %]</a></p> >+<p>You selected a record from an external source that matches an existing record in your catalog: [% IF ( BiblioDefaultViewmarc ) %]<a target="_blank" title="Open in new window" href="/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=[% biblionumber |url %]"> >+[% ELSIF ( BiblioDefaultViewlabeled_marc ) %]<a target="_blank" title="Open in new window" href="/cgi-bin/koha/catalogue/labeledMARCdetail.pl?biblionumber=[% biblionumber |url %]"> >+[% ELSIF ( BiblioDefaultViewisbd ) %]<a target="_blank" title="Open in new window" href="/cgi-bin/koha/catalogue/ISBDdetail.pl?biblionumber=[% biblionumber |url %]"> >+[% ELSE %]<a target="_blank" title="Open in new window" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% biblionumber |url %]">[% END %] <i class="fa fa-window-restore"></i> [% duplicatetitle | html %]</a></p> > </div> > > <div class="row"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >index 635b6cceb3..8cbd2de655 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >@@ -475,7 +475,7 @@ > [% IF ( duplicatebiblionumber ) %] > <div class="dialog alert"> > <h3>Duplicate record suspected</h3> >- <p>Is this a duplicate of <a class="popup" href="/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=[% duplicatebiblionumber | html %]" onclick="openWindow('/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=[% duplicatebiblionumber | html %]&popup=1', 'DuplicateBiblio','800','600'); return false;">[% duplicatetitle | html %]</a> ?</p> >+ <p>Is this a duplicate of <a href="/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=[% duplicatebiblionumber | uri %]" onclick="openWindow('/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=[% duplicatebiblionumber | uri %]&popup=1', 'DuplicateBiblio','800','600'); return false;">[% duplicatetitle | html %] <i class="fa fa-window-restore"></i></a> ?</p> > [% IF ( CAN_user_editcatalogue_edit_items ) %] > <form action="/cgi-bin/koha/cataloguing/additem.pl" method="get"> > <input type="hidden" name="biblionumber" value="[% duplicatebiblionumber | html %]" /> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index 7c78ca7768..5cfc0912ae 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -434,7 +434,7 @@ > [% FOREACH book IN options %] > <tr> > <td> >- <a class="popup" target="_blank" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% book.biblionumber | html %]">[% book.title | html %]</a> >+ <a target="_blank" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% book.biblionumber | html %]">[% book.title | html %] <i class="fa fa-window-restore"></i></a> > [% book.barcode | html %] > </td> > <td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index f36d98314b..3bd65581b6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -66,7 +66,7 @@ > [% IF ( check_member ) %] > <div class="dialog alert"> > <h3>Duplicate patron record?</h3> >- <p><a class="popup" href="#" onclick="Dopop('moremember.pl?print=brief&borrowernumber=[% check_member | html %]');return false;" >View existing record</a></p> >+ <p><a href="#" onclick="Dopop('moremember.pl?print=brief&borrowernumber=[% check_member | html %]');return false;" ><i class="fa fa-window-restore"></i> View existing record</a></p> > <button id="duplicate" type="submit" class="new"><i class="fa fa-pencil"></i> It is a duplicate. > Edit existing record</button> > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23958
:
95032
|
95242
| 95746