Bugzilla – Attachment 95784 Details for
Bug 10352
Cataloguing log search mixing itemnumber/bibnumber
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10352: Use a new object_type parameter instead of the module's name
Bug-10352-Use-a-new-objecttype-parameter-instead-o.patch (text/plain), 2.98 KB, created by
Nick Clemens
on 2019-11-25 12:17:56 UTC
(
hide
)
Description:
Bug 10352: Use a new object_type parameter instead of the module's name
Filename:
MIME Type:
Creator:
Nick Clemens
Created:
2019-11-25 12:17:56 UTC
Size:
2.98 KB
patch
obsolete
>From 651f90ec4d11d785462b8b1df651778172f60f2d Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 25 Nov 2019 11:28:40 +0100 >Subject: [PATCH] Bug 10352: Use a new object_type parameter instead of the > module's name > >To dissociate a search on biblio and item, we pass a new "object_type" >parameter to viewlog.pl. If equals 'biblio' we will assume that "object" >contains a biblionumber > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc | 2 +- > tools/viewlog.pl | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc >index d13312a0df..2080b07707 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc >@@ -39,7 +39,7 @@ > <ul> > [% IF ( issuehistoryview ) %]<li class="active">[% ELSE %]<li>[% END %] > <a href="/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=[% biblio_object_id | url %]" >Checkout history</a></li> >-[% IF ( CAN_user_tools_view_system_logs ) %][% IF ( logview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=CATALOGUING&action=MODIFY&object=[% biblio_object_id | url %]">Modification log</a> </li>[% END %] >+[% IF ( CAN_user_tools_view_system_logs ) %][% IF ( logview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=CATALOGUING&action=MODIFY&object=[% biblio_object_id | url %]&object_type=biblio">Modification log</a> </li>[% END %] > [% IF ( CAN_user_stockrotation_manage_rota_items && Koha.Preference('StockRotation') ) %][% IF ( stockrotationview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/catalogue/stockrotation.pl?biblionumber=[% biblio_object_id | uri %]">Rota</a> </li>[% END %] > </ul> > </div> >diff --git a/tools/viewlog.pl b/tools/viewlog.pl >index 40e1c6658a..94c7ecb3ea 100755 >--- a/tools/viewlog.pl >+++ b/tools/viewlog.pl >@@ -54,6 +54,7 @@ my $user = $input->param("user") // ''; > my @actions = $input->multi_param("actions"); > my @interfaces = $input->multi_param("interfaces"); > my $object = $input->param("object"); >+my $object_type = $input->param("object_type"); > my $info = $input->param("info"); > my $datefrom = $input->param("from"); > my $dateto = $input->param("to"); >@@ -135,7 +136,7 @@ if ($do_it) { > $search_params{interface} = { -in => [ @interfaces ] } if ( defined $interfaces[0] && $interfaces[0] ne '' ); > > >- if ( @modules == 1 && $modules[0] eq 'CATALOGUING' ) { >+ if ( @modules == 1 && $object_type eq 'biblio' ) { > # Handle 'Modification log' from cataloguing > my @itemnumbers = Koha::Items->search({ biblionumber => $object })->get_column('itemnumber'); > $search_params{'-or'} = [ >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10352
:
89668
|
91466
|
95776
|
95783
|
95784
|
95785
|
95786
|
96273
|
96336
|
97147
|
97148
|
97149
|
97150