From c24d0cc889be494daeaf300674ec8b09424004fd Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Mon, 2 Dec 2019 11:41:11 +0000 Subject: [PATCH] Bug 19288: Don't show patron info for item level holds on details.pl unless hold is waiting This persists after bug 20948 - we can still display patron information even if this patron is not the one who will receive the item upon checkin. The holds tab can give an overview of holds and information - I think on the details page the only info we need is whether there might be a item level hold, not who it is for To test: 1 - Place an item level hold for delivery at a branch not matching home branch of item 2 - Place a record level hold for delivery at homebranch of item placed on hold above 3 - Enable LocalHoldsPriority with 'pickup library' matches the item's 'home library' 4 - View the details for the page, it says the item has a hold for the patron with an item level hold 5 - Check in the item, the hold triggered is for the next available patron, ignore the hold 6 - Apply patch 7 - Check details page, 'There is an item-level hold (priority=1)' with no patron info 8 - Check in, next available hold is still the one triggered --- koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt index c63ae89e6f..99486d712c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt @@ -359,15 +359,13 @@ [% IF hold %] [% IF hold.waitingdate %] Waiting at [% Branches.GetName( hold.branchcode ) | html %] since [% hold.waitingdate | $KohaDates %]. - [% ELSIF hold.priority == 1 %] - Item-level hold (placed [% hold.reservedate | $KohaDates %]) for delivery at [% Branches.GetName( hold.branchcode ) | html %]. - [% ELSE %] - There is an item level hold on this item (priority = [% hold.priority %]). - [% END %] [% IF canreservefromotherbranches AND ( hold.waitingdate OR hold.priority == 1 ) %] Hold for: [% INCLUDE 'patron-title.inc' patron=hold.borrower hide_patron_infos_if_needed=1 %] [% END %] + [% ELSE %] + There is an item level hold on this item (priority = [% hold.priority %]). + [% END %] [% END %] [% UNLESS ( item.itemnotforloan || item.notforloan_per_itemtype || item.onloan || item.itemlost || item.withdrawn || item.damaged || item.transfertwhen || hold ) %] Available -- 2.11.0