From 3f07d4894f11cff22bf7c46315e347471b0d30b9 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 6 Aug 2019 11:14:25 -0500 Subject: [PATCH] Bug 23463: Remove ModItem There should not be any calls left --- C4/Items.pm | 64 ------------------------------------------------------------- 1 file changed, 64 deletions(-) diff --git a/C4/Items.pm b/C4/Items.pm index 97280f922b..99f06f6cd2 100644 --- a/C4/Items.pm +++ b/C4/Items.pm @@ -31,7 +31,6 @@ BEGIN { AddItemBatchFromMarc ModItemFromMarc Item2Marc - ModItem ModDateLastSeen ModItemTransfer DelItem @@ -375,69 +374,6 @@ sub ModItemFromMarc { return $item_object->get_from_storage->unblessed; } -=head2 ModItem - -ModItem( - { column => $newvalue }, - $biblionumber, - $itemnumber, - { - [ unlinked_item_subfields => $unlinked_item_subfields, ] - [ log_action => 1, ] - } -); - -Change one or more columns in an item record. - -The first argument is a hashref mapping from item column -names to the new values. The second and third arguments -are the biblionumber and itemnumber, respectively. -The fourth, optional parameter (additional_params) may contain the keys -unlinked_item_subfields and log_action. - -C<$unlinked_item_subfields> contains an arrayref containing -subfields present in the original MARC -representation of the item (e.g., from the item editor) that are -not mapped to C columns directly but should instead -be stored in C and included in -the biblio items tag for display and indexing. - -If one of the changed columns is used to calculate -the derived value of a column such as C, -this routine will perform the necessary calculation -and set the value. - -If log_action is set to false, the action will not be logged. -If log_action is true or undefined, the action will be logged. - -=cut - -sub ModItem { - my ( $item, $biblionumber, $itemnumber, $additional_params ) = @_; - my $log_action = $additional_params->{log_action} // 1; - - _set_derived_columns_for_mod($item); - _do_column_fixes_for_mod($item); - # FIXME add checks - # duplicate barcode - # attempt to change itemnumber - # attempt to change biblionumber (if we want - # an API to relink an item to a different bib, - # it should be a separate function) - - # update items table - _koha_modify_item($item); - - # request that bib be reindexed so that searching on current - # item status is possible - ModZebra( $biblionumber, "specialUpdate", "biblioserver" ); - - _after_item_action_hooks({ action => 'modify', item_id => $itemnumber }); - - logaction( "CATALOGUING", "MODIFY", $itemnumber, "item " . Dumper($item) ) - if $log_action && C4::Context->preference("CataloguingLog"); -} - =head2 ModItemTransfer ModItemTransfer($itenumber, $frombranch, $tobranch); -- 2.11.0