Bugzilla – Attachment 96040 Details for
Bug 24164
Patron emailer cronjob is not generating unique content for notices
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24164: Copy the letter for each email
Bug-24164-Copy-the-letter-for-each-email.patch (text/plain), 1.38 KB, created by
ByWater Sandboxes
on 2019-12-05 14:26:02 UTC
(
hide
)
Description:
Bug 24164: Copy the letter for each email
Filename:
MIME Type:
Creator:
ByWater Sandboxes
Created:
2019-12-05 14:26:02 UTC
Size:
1.38 KB
patch
obsolete
>From ae96dfef9b5ff363016cb8eccc45767d992e9c26 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 3 Dec 2019 19:55:19 +0000 >Subject: [PATCH] Bug 24164: Copy the letter for each email > >To test: >1 - Set or have two patrons with emails - note thier borrowernumber for the report >2 - Create a report - note the report id >SELECT borrowernumber, surname, firstname WHERE borrowernumber IN (##,##); >3 - Create a notice in circulation with code TESTEMAIL >4 - The content should be "[% surname %]" >5 - perl misc/cronjobs/patron_emailer.pl --report ## --notice TESTEMAIL --module circulation --from anyone@anywhere.com --verbose >6 - Note that the emails both have the same surname >7 - Apply patch >8 - Repeat 5 >9 - Emails now have correct content > >Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> >--- > C4/Reports/Guided.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Reports/Guided.pm b/C4/Reports/Guided.pm >index e20c99b8fc..84fd843c7f 100644 >--- a/C4/Reports/Guided.pm >+++ b/C4/Reports/Guided.pm >@@ -1029,7 +1029,7 @@ sub EmailReport { > > $letter->{content} = $content; > $email->{borrowernumber} = $row->{borrowernumber}; >- $email->{letter} = $letter; >+ $email->{letter} = { %$letter }; > $email->{from_address} = $from_address; > $email->{to_address} = $to_address; > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24164
:
95982
|
95983
|
96040
|
96211
|
96220
|
96221