From aaea03643a9d40c0e6c3fa59f92788047e72d83e Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Wed, 16 May 2012 08:01:06 -0400 Subject: [PATCH] Bug 7703 - Don't block bulk hold action on search results if some items can't be placed on hold In the staff client if you check multiple lines in search results and click the button to "place hold" you might be blocked from proceeding because "One or more selected items cannot be placed on hold." The next stage of the holds process is perfectly capable of warning the user about such problems. The user should not have to search back through the list of items they checked to find which one to un-check. Fixed by not disabling the submit button in the event that one of the records has no holdable items. Updated text of submit buttons. --- .../prog/en/modules/reserve/request.tt | 6 +++--- reserve/request.pl | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt index eba6756..e9cb05d 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ -550,11 +550,11 @@ function checkMultiHold() {
[% IF ( borrowernumber ) %] [% IF ( override_required ) %] - + [% ELSIF ( none_available ) %] - + [% ELSE %] - + [% END %] [% END %]
diff --git a/reserve/request.pl b/reserve/request.pl index ff01850..d700ed4 100755 --- a/reserve/request.pl +++ b/reserve/request.pl @@ -466,7 +466,7 @@ foreach my $biblionumber (@biblionumbers) { } elsif ( C4::Context->preference('AllowHoldPolicyOverride') ) { -# If AllowHoldPolicyOverride is set, it should override EVERY restriction, not just branch item rules + # If AllowHoldPolicyOverride is set, it should override EVERY restriction, not just branch item rules $item->{override} = 1; $num_override++; } -- 1.7.2.5