Bugzilla – Attachment 96146 Details for
Bug 24121
Item types icons in intra search results are requesting icons from opac images path
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24121 - Item types icons in intra search results are requesting icons from opac images path if item-level_itypes syspref is set to biblio
0001-Bug-24121-Item-types-icons-in-intra-search-results-a.patch (text/plain), 1.75 KB, created by
Pedro Amorim
on 2019-12-10 12:26:20 UTC
(
hide
)
Description:
Bug 24121 - Item types icons in intra search results are requesting icons from opac images path if item-level_itypes syspref is set to biblio
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2019-12-10 12:26:20 UTC
Size:
1.75 KB
patch
obsolete
>From 28cda3af9a061d8f094d1fbf38a8ad187b6b2e7c Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pjamorim91@gmail.com> >Date: Tue, 10 Dec 2019 11:17:59 -0100 >Subject: [PATCH] Bug 24121- Item types icons in intra search results are > requesting icons from opac images path if item-level_itypes syspref is set to > biblio >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > > When searching in INTRA you'll notice the item type icons not showing. > > To test: > 1) Set syspref item-level_itypes to biblio > 2) Confirm that there is a biblioitems.itemtype mapping to a MARC field > 3) Verify that item type icons are set for all the types > 4) Perform a search where biblios with said MARC field is filled with a type value > 5) Verify that where the icon should appear, it's showing the browser icon for image not found > 6) Apply patch. > 7) Repeat step 4. > 8) Observe the icons are now displayed correctly > > Sponsored-by: Governo Regional dos Açores >--- > C4/Search.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Search.pm b/C4/Search.pm >index 9f39b50..a6657e7 100644 >--- a/C4/Search.pm >+++ b/C4/Search.pm >@@ -1941,7 +1941,7 @@ sub searchResults { > $oldbiblio->{result_number} = $i + 1; > > # add imageurl to itemtype if there is one >- $oldbiblio->{imageurl} = getitemtypeimagelocation( $search_context, $itemtypes{ $oldbiblio->{itemtype} }->{imageurl} ); >+ $oldbiblio->{imageurl} = getitemtypeimagelocation( $search_context->{'interface'}, $itemtypes{ $oldbiblio->{itemtype} }->{imageurl} ); > > $oldbiblio->{normalized_upc} = GetNormalizedUPC( $marcrecord,$marcflavour); > $oldbiblio->{normalized_ean} = GetNormalizedEAN( $marcrecord,$marcflavour); >-- >2.7.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24121
:
95827
|
96146
|
96194
|
96506
|
96575