Bugzilla – Attachment 96253 Details for
Bug 24240
List on opac missing close form tag under some conditions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24240: Move form closing tag outside of conditional
Bug-24240-Move-form-closing-tag-outside-of-conditi.patch (text/plain), 2.00 KB, created by
Nick Clemens
on 2019-12-13 14:26:00 UTC
(
hide
)
Description:
Bug 24240: Move form closing tag outside of conditional
Filename:
MIME Type:
Creator:
Nick Clemens
Created:
2019-12-13 14:26:00 UTC
Size:
2.00 KB
patch
obsolete
>From 289abd9fdcc7882492009299814d6b544a923b49 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 13 Dec 2019 14:24:33 +0000 >Subject: [PATCH] Bug 24240: Move form closing tag outside of conditional > >To test: >1 - Create a public list >2 - View the list as a user not signed in >3 - Validate the HTML, note the div closed with open elements, and a form tag unclosed >4 - Apply patch >5 - Those errors are fixed >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >index d96c4a3684..5e9f40d3f2 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >@@ -547,15 +547,14 @@ > <input type="hidden" name="shelfnumber" value="[% shelf.shelfnumber | html %]" /> > <input type="hidden" name="modifyshelfcontents" value="1" /> > <input type="submit" value="Remove selected items" id="remove-selected" class="btn btn-danger"/> >- </form> > [% ELSIF !itemsloop && can_manage_shelf %] > <form method="post" action="opac-shelves.pl"> > <input type="hidden" name="op" value="delete" /> > <input type="hidden" name="referer" value="list" /> > <input type="hidden" name="shelfnumber" value="[% shelf.shelfnumber | html %]"/> > <input type="submit" class="btn btn-danger" value="Delete this list" onclick="return confirmDelete(MSG_CONFIRM_DELETE_LIST)" /> >- </form> > [% END %] >+ </form> <!-- / myform --> > > [% IF op == 'add_form' OR op == 'edit_form' %] > <form method="post" action="/cgi-bin/koha/opac-shelves.pl"> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24240
:
96253
|
96298
|
96314