Bugzilla – Attachment 96286 Details for
Bug 24085
Double submission of forms on returns.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24085: Make print and cancel-hold buttons instead of submit
Bug-24085-Make-print-and-cancel-hold-buttons-inste.patch (text/plain), 4.77 KB, created by
Owen Leonard
on 2019-12-13 23:04:03 UTC
(
hide
)
Description:
Bug 24085: Make print and cancel-hold buttons instead of submit
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2019-12-13 23:04:03 UTC
Size:
4.77 KB
patch
obsolete
>From c3f08697d801eb9c9cb074fa3c2ab75aa9b17741 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 13 Dec 2019 23:01:05 +0000 >Subject: [PATCH] Bug 24085: Make print and cancel-hold buttons instead of > submit > > To test: > 1 - Place a hold on an item > 2 - Check in the item to trigger the hold > 3 - Test both the print and cancel buttons to make sure all looks > correct > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index d8aad43003..05c2eae869 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -474,11 +474,11 @@ > </button> > > <input type="hidden" name="print_slip" value="0" /> >- <button type="submit" class="btn btn-default print"> >+ <button type="button" class="btn btn-default print"> > <i class="fa fa-print"></i> Print slip and confirm > </button> > >- <button type="submit" class="btn btn-default deny cancel-hold"> >+ <button type="button" class="btn btn-default deny cancel-hold"> > <i class="fa fa-times"></i> Cancel hold > </button> > </div> <!-- /.modal-footer --> >@@ -521,7 +521,7 @@ > <div class="modal-footer"> > [% IF !transfer %] > <button type="submit" name="dotransfer" value="Yes" class="btn btn-default approve"><i class="fa fa-check"></i> Yes</button> >- <button type="submit" name="dotransfer" value="Yes" class="btn btn-default print openWin" data-url="transfer-slip.pl?transferitem=[% itemnumber | uri %]&&branchcode=[% returnbranch | uri %]&op=slip"><i class="fa fa-print"></i> Yes, print slip</button> >+ <button type="button" name="dotransfer" value="Yes" class="btn btn-default print openWin" data-url="transfer-slip.pl?transferitem=[% itemnumber | uri %]&&branchcode=[% returnbranch | uri %]&op=slip"><i class="fa fa-print"></i> Yes, print slip</button> > <button type="button" data-dismiss="modal" class="btn btn-default deny" name="notransfer" value="No"><i class="fa fa-times"></i> No</button> > [% ELSE %] > <button type="button" data-dismiss="modal" class="btn btn-default approve"><i class="fa fa-check"></i> OK</button> >@@ -636,14 +636,14 @@ > <button type="submit" class="btn btn-default approve"> > <i class="fa fa-check"></i> Confirm hold and transfer > </button> >- <button type="submit" class="btn btn-default print"> >+ <button type="button" class="btn btn-default print"> > <i class="fa fa-print"></i> Print slip, transfer, and confirm > </button> > [% ELSE %] > <button type="submit" class="btn btn-default approve"> > <i class="fa fa-check"></i> Confirm hold > </button> >- <button type="submit" class="btn btn-default print"> >+ <button type="button" class="btn btn-default print"> > <i class="fa fa-print"></i> Print slip and confirm > </button> > [% END %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24085
:
95708
|
95839
|
96286
|
96313