From f8494e561047e739c86c5744ec807ca0c0938ed2 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 17 Dec 2019 12:10:28 +0100 Subject: [PATCH] Bug 24171: Preserve auto_renew when triggering itemBarcodeFallbackSearch The auto_renew parameter is not sent to the template when the popup triggered by itemBarcodeFallbackSearch is displayed. Test plan: - Turn on OnSiteCheckouts and Itemfallbacksearch - Open a patron account - Check the checkboxes for automatic-renewal and on-site checkout - Search for a title keyword in the checkout input box - Verify that auto-renewal flag is set Note for QA: The auto_renew flag will be set in any cases. Should we expect regression? --- circ/circulation.pl | 3 ++- koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/circ/circulation.pl b/circ/circulation.pl index 5bc227d032..a07b691607 100755 --- a/circ/circulation.pl +++ b/circ/circulation.pl @@ -204,6 +204,8 @@ else { $session->clear('auto_renew'); } +$template->param( auto_renew => $session->param('auto_renew') ); + my ($datedue,$invalidduedate); my $duedatespec_allow = C4::Context->preference('SpecifyDueDate'); @@ -427,7 +429,6 @@ if (@$barcodes) { $template_params->{getTitleMessageIteminfo} = $biblio->title; $template_params->{getBarcodeMessageIteminfo} = $item->barcode; $template_params->{NEEDSCONFIRMATION} = 1; - $template_params->{auto_renew} = $session->param('auto_renew'); $confirm_required = 1; } } diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt index 71809af850..afccab3c08 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt @@ -449,6 +449,7 @@ + -- 2.11.0