Bugzilla – Attachment 96374 Details for
Bug 23883
sip_cli_emulator.pl - typo in parameter name
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23883: SIP - Fix typo in parameter name
Bug-23883-SIP---Fix-typo-in-parameter-name.patch (text/plain), 1.21 KB, created by
Jonathan Druart
on 2019-12-17 13:38:17 UTC
(
hide
)
Description:
Bug 23883: SIP - Fix typo in parameter name
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2019-12-17 13:38:17 UTC
Size:
1.21 KB
patch
obsolete
>From 4f5050c8cb9ec7e64eaa0a70c4a5fdb7b8eead99 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 17 Dec 2019 14:35:19 +0100 >Subject: [PATCH] Bug 23883: SIP - Fix typo in parameter name > >The options of the script have hypens whereas the hash keys have >underscore. >In my understanding the problem only occurs on display purpose. > >Test plan: >Try a sip command like > % perl misc/sip_cli_emulator.pl -a localhost -su term1 -sp term1 -l CPL -m fee_paid > >Without this patch you will see: > fee_amount is required for fee_paid >With this patch the correct option is listed: > fee-amount is required for fee_paid >--- > misc/sip_cli_emulator.pl | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/misc/sip_cli_emulator.pl b/misc/sip_cli_emulator.pl >index 5f4b326a26..1b987279b5 100755 >--- a/misc/sip_cli_emulator.pl >+++ b/misc/sip_cli_emulator.pl >@@ -320,6 +320,7 @@ sub build_command_message { > foreach my $key ( keys %$parameters ) { > unless ( $parameters->{$key} ) { > unless ( $optional{$key} ) { >+ $key =~ s|_|-|g; # options of this script have hyphens > say "$key is required for $message"; > return; > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23883
:
96374
|
96382