Bugzilla – Attachment 96381 Details for
Bug 24016
manager_id in Koha::Patron::Message->store should not depend on userenv alone
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24016: (QA follow-up) Format code to adhere to perltidy format
Bug-24016-QA-follow-up-Format-code-to-adhere-to-pe.patch (text/plain), 1.13 KB, created by
Joonas Kylmälä
on 2019-12-17 14:15:03 UTC
(
hide
)
Description:
Bug 24016: (QA follow-up) Format code to adhere to perltidy format
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2019-12-17 14:15:03 UTC
Size:
1.13 KB
patch
obsolete
>From 2c8c70a581ed330bd49b3e29c747839dea3dbcd2 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi> >Date: Tue, 17 Dec 2019 13:59:55 +0000 >Subject: [PATCH] Bug 24016: (QA follow-up) Format code to adhere to perltidy > format >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> >--- > Koha/Patron/Message.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/Patron/Message.pm b/Koha/Patron/Message.pm >index 838378011b3..10ef58c20ef 100644 >--- a/Koha/Patron/Message.pm >+++ b/Koha/Patron/Message.pm >@@ -49,9 +49,9 @@ sub store { > and $self->message_type > and $self->branchcode; > >- unless (defined $self->manager_id) { >+ unless ( defined $self->manager_id ) { > my $userenv = C4::Context->userenv; >- $self->manager_id( $userenv ? $userenv->{number} : undef); >+ $self->manager_id( $userenv ? $userenv->{number} : undef ); > } > > C4::Log::logaction( "MEMBERS", "ADDCIRCMESSAGE", $self->borrowernumber, $self->message ) >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24016
:
95299
|
95300
|
95301
|
95302
|
95461
|
95462
|
96379
|
96380
| 96381 |
96761