Bugzilla – Attachment 96590 Details for
Bug 24166
Barcode removal breaks circulation.pl/moremember.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24166: Do not hang when displaying checkout list if barcode is not set
Bug-24166-Do-not-hang-when-displaying-checkout-lis.patch (text/plain), 1.91 KB, created by
Katrin Fischer
on 2019-12-22 22:00:34 UTC
(
hide
)
Description:
Bug 24166: Do not hang when displaying checkout list if barcode is not set
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2019-12-22 22:00:34 UTC
Size:
1.91 KB
patch
obsolete
>From f68b1807aea33a1c9bfcc13b9eef5502d0986ce8 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 18 Dec 2019 11:09:51 +0100 >Subject: [PATCH] Bug 24166: Do not hang when displaying checkout list if > barcode is not set > >If a barcode is not set, there is a JS error in the log: > TypeError: oObj.barcode is null >We should not call escapeHtml() on it if not barcode is set for a given >item. > >Test plan: >Check an item out >Remove its barcode >Load the checkout list >=> Without this patch you get the "loading" popup and the table is never >displayed >=> With this patch applied you see the checkout list > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >index 01be72b763..0d73aed520 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >@@ -338,7 +338,7 @@ $(document).ready(function() { > + "#" > + oObj.itemnumber > + "'>" >- + oObj.barcode.escapeHtml() >+ + (oObj.barcode ? oObj.barcode.escapeHtml() : "") > + "</a>" > + onsite_checkout > >@@ -721,7 +721,7 @@ $(document).ready(function() { > + "#" > + oObj.itemnumber > + "'>" >- + oObj.barcode.escapeHtml() >+ + (oObj.barcode ? oObj.barcode.escapeHtml() : "") > + "</a>" > + onsite_checkout; > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24166
:
96409
|
96413
| 96590