From 1facebf85b9d195cf3805c1b8f3935ed71f32687 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 27 Dec 2019 15:21:27 +0100 Subject: [PATCH] Bug 23893: No special care for booleans Tests pass without that changes. If we need them they should be at Koha::Object anyway. About the date, I also think that that should be moved to Koha::Object (we can guess it, like we do in Koha::Object->store, retrieve the datatype and adjust). Also we can send a DT object to DBIC, no need for an sql formatted date --- Koha/Patron.pm | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/Koha/Patron.pm b/Koha/Patron.pm index b6e854edf2..4038ddf94e 100644 --- a/Koha/Patron.pm +++ b/Koha/Patron.pm @@ -1571,20 +1571,12 @@ sub attributes_from_api { $attrs = $self->SUPER::attributes_from_api( $attrs ); - if ( exists $attrs->{lost} ) { - $attrs->{lost} = ($attrs->{lost}) ? 1 : 0; - } - - if ( exists $attrs->{ gonenoaddress} ) { - $attrs->{gonenoaddress} = ($attrs->{gonenoaddress}) ? 1 : 0; - } - if ( exists $attrs->{lastseen} ) { - $attrs->{lastseen} = output_pref({ str => $attrs->{lastseen}, dateformat => 'sql' }); + $attrs->{lastseen} = dt_from_string($attrs->{lastseen}); } if ( exists $attrs->{updated_on} ) { - $attrs->{updated_on} = output_pref({ str => $attrs->{updated_on}, dateformat => 'sql' }); + $attrs->{updated_on} = dt_from_string($attrs->{updated_on}); } return $attrs; -- 2.11.0