From bd2117514237e8b1d1ed1766836dc5b584882d80 Mon Sep 17 00:00:00 2001 From: Cori Lynn Arnold Date: Tue, 31 Dec 2019 17:10:14 +0000 Subject: [PATCH] Bug 24323: Advanced editor - Invalid 008 with helper silently fails to save This patch adds a "else if" to fall through if the error message isn't one of the previously defined ones ("syntax" and "invalid") and presents the human with a generic message that "Something went wrong, cannot save." Prior to testing: a/Verify that Advanced Editor is enabled b/Download the errorrecord.mrc from bug To test: 1/Apply patch 2/Go to Cataloging->Advanced Editor 3/Click "Import Record" button and navigate to the record saved from step b/ 4/Add an 003 field (as required by the default cataloging config) 5/Hit "Save to catalog" 6/Verify that a message is passed to the user that the file was unable to be saved --- koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc index 78d1f502f1..35b81089d5 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc @@ -879,6 +879,8 @@ require( [ 'koha-backend', 'search', 'macros', 'marc-editor', 'marc-record', 'pr humanMsg.displayAlert( _("Incorrect syntax, cannot save"), { className: 'humanError' } ); } else if ( result.error == 'invalid' ) { humanMsg.displayAlert( _("Record structure invalid, cannot save"), { className: 'humanError' } ); + } else if ( result.error ) { + humanMsg.displayAlert( _("Something went wrong, cannot save"), { className: 'humanError' } ); } else if ( !result.error ) { humanMsg.displayAlert( _("Record saved "), { className: 'humanSuccess' } ); } -- 2.11.0