From 15864082f2b0bd85d5cbdda032a29f9fad5bcd37 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Thu, 2 Jan 2020 15:15:01 +0000 Subject: [PATCH] Bug 24016: (RM follow-up) Remove userenv requirement entirely Koha::* Object based classes would not require a userenv to be set to function correctly at all. --- Koha/Patron/Message.pm | 5 ----- circ/add_message.pl | 1 + 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/Koha/Patron/Message.pm b/Koha/Patron/Message.pm index 10ef58c20e..a928fa5a01 100644 --- a/Koha/Patron/Message.pm +++ b/Koha/Patron/Message.pm @@ -49,11 +49,6 @@ sub store { and $self->message_type and $self->branchcode; - unless ( defined $self->manager_id ) { - my $userenv = C4::Context->userenv; - $self->manager_id( $userenv ? $userenv->{number} : undef ); - } - C4::Log::logaction( "MEMBERS", "ADDCIRCMESSAGE", $self->borrowernumber, $self->message ) if C4::Context->preference("BorrowersLog"); diff --git a/circ/add_message.pl b/circ/add_message.pl index 67a6844c43..84448b1e7e 100755 --- a/circ/add_message.pl +++ b/circ/add_message.pl @@ -46,6 +46,7 @@ my $batch = $input->param('batch'); Koha::Patron::Message->new( { borrowernumber => $borrowernumber, + manager_id => $loggedinuser, branchcode => $branchcode, message_type => $message_type, message => $borrower_message, -- 2.20.1