Bugzilla – Attachment 96773 Details for
Bug 24327
Anonymous suggestions should not be allowed if AnonymousPatron misconfigured
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24327: Redirect to the login form if AnonSuggestion misconfigured
Bug-24327-Redirect-to-the-login-form-if-AnonSugges.patch (text/plain), 1.37 KB, created by
Katrin Fischer
on 2020-01-02 22:01:18 UTC
(
hide
)
Description:
Bug 24327: Redirect to the login form if AnonSuggestion misconfigured
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2020-01-02 22:01:18 UTC
Size:
1.37 KB
patch
obsolete
>From 69bc78e994e93c4f6a1db5a9ae5df53c694b88b8 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 2 Jan 2020 11:38:18 +0100 >Subject: [PATCH] Bug 24327: Redirect to the login form if AnonSuggestion > misconfigured > >Test plan: >Turn on AnonSuggestion but set AnonymousPatron to an invalid value >Go to /cgi-bin/koha/opac-suggestions.pl?op=add >=> You see the login form > >Signed-off-by: hc <hc@interleaf.ie> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > opac/opac-suggestions.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/opac/opac-suggestions.pl b/opac/opac-suggestions.pl >index b502e92737..9f7337be62 100755 >--- a/opac/opac-suggestions.pl >+++ b/opac/opac-suggestions.pl >@@ -66,7 +66,7 @@ my ( $template, $borrowernumber, $cookie, @messages ); > my $deleted = $input->param('deleted'); > my $submitted = $input->param('submitted'); > >-if ( C4::Context->preference("AnonSuggestions") or ( C4::Context->preference("OPACViewOthersSuggestions") and $op eq 'else' ) ) { >+if ( ( C4::Context->preference("AnonSuggestions") and Koha::Patrons->find( C4::Context->preference("AnonymousPatron") ) ) or ( C4::Context->preference("OPACViewOthersSuggestions") and $op eq 'else' ) ) { > ( $template, $borrowernumber, $cookie ) = get_template_and_user( > { > template_name => "opac-suggestions.tt", >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24327
:
96730
|
96731
|
96746
|
96747
|
96772
| 96773