View | Details | Raw Unified | Return to bug 23473
Collapse All | Expand All

(-)a/Koha/Patrons/Import.pm (-2 / +6 lines)
Lines 73-78 sub import_patrons { Link Here
73
    my $defaults             = $params->{defaults};
73
    my $defaults             = $params->{defaults};
74
    my $ext_preserve         = $params->{preserve_extended_attributes};
74
    my $ext_preserve         = $params->{preserve_extended_attributes};
75
    my $overwrite_cardnumber = $params->{overwrite_cardnumber};
75
    my $overwrite_cardnumber = $params->{overwrite_cardnumber};
76
    my $overwrite_passwords  = $params->{overwrite_passwords};
76
    my $extended             = C4::Context->preference('ExtendedPatronAttributes');
77
    my $extended             = C4::Context->preference('ExtendedPatronAttributes');
77
    my $set_messaging_prefs  = C4::Context->preference('EnhancedMessagingPreferences');
78
    my $set_messaging_prefs  = C4::Context->preference('EnhancedMessagingPreferences');
78
79
Lines 242-249 sub import_patrons { Link Here
242
                # use values from extant patron unless our csv file includes this column or we provided a default.
243
                # use values from extant patron unless our csv file includes this column or we provided a default.
243
                # FIXME : You cannot update a field with a  perl-evaluated false value using the defaults.
244
                # FIXME : You cannot update a field with a  perl-evaluated false value using the defaults.
244
245
245
                # The password is always encrypted, skip it!
246
                # The password is always encrypted, skip it unless we are forcing overwrite!
246
                next if $col eq 'password';
247
                next if $col eq 'password' && !$overwrite_passwords;
247
248
248
                unless ( exists( $csvkeycol{$col} ) || $defaults->{$col} ) {
249
                unless ( exists( $csvkeycol{$col} ) || $defaults->{$col} ) {
249
                    $borrower{$col} = $member->{$col} if ( $member->{$col} );
250
                    $borrower{$col} = $member->{$col} if ( $member->{$col} );
Lines 288-293 sub import_patrons { Link Here
288
                    );
289
                    );
289
                }
290
                }
290
            }
291
            }
292
            if ($overwrite_passwords){
293
                $patron->set_password({ password => $borrower{password} });
294
            }
291
            if ($extended) {
295
            if ($extended) {
292
                if ($ext_preserve) {
296
                if ($ext_preserve) {
293
                    my $old_attributes = GetBorrowerAttributes($borrowernumber);
297
                    my $old_attributes = GetBorrowerAttributes($borrowernumber);
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt (-1 / +14 lines)
Lines 220-225 Link Here
220
220
221
                <li class="radio">
221
                <li class="radio">
222
                    <input type="radio" id="overwrite_cardnumberyes" name="overwrite_cardnumber" value="1" /><label for="overwrite_cardnumberyes">Overwrite the existing one with this</label>
222
                    <input type="radio" id="overwrite_cardnumberyes" name="overwrite_cardnumber" value="1" /><label for="overwrite_cardnumberyes">Overwrite the existing one with this</label>
223
                    <ul>
224
                        <li>
225
                            <input type="checkbox" id="overwrite_passwords" name="overwrite_passwords" disabled="true"/>
226
                            <label for="overwrite_passwords">Replace patron passwords with those in the file</label>
227
                        </li
228
                    </ul>
223
                </li>
229
                </li>
224
            </ol>
230
            </ol>
225
        </fieldset>
231
        </fieldset>
Lines 276-282 Link Here
276
        </li>
282
        </li>
277
283
278
        <li>
284
        <li>
279
            'password' should be stored in plaintext, and will be converted to a Bcrypt hash (if your passwords are already encrypted, talk to your system administrator about options).
285
            'password' should be stored in plaintext, and will be converted to a Bcrypt hash (if your passwords are already encrypted, talk to your system administrator about options). Passwords will not be updated on overwrite unless replace passwords option is checked.
280
        </li>
286
        </li>
281
287
282
        <li>
288
        <li>
Lines 313-318 you can supply dates in ISO format (e.g., '2010-10-28'). Link Here
313
                $(".expand_defaults").toggle();
319
                $(".expand_defaults").toggle();
314
            });
320
            });
315
        });
321
        });
322
323
        $("#overwrite_cardnumberno").click(function(){
324
            $("#overwrite_passwords").prop('checked',false).prop('disabled',true);
325
        });
326
        $("#overwrite_cardnumberyes").click(function(){
327
            $("#overwrite_passwords").prop('disabled',false);
328
        });
316
    </script>
329
    </script>
317
[% END %]
330
[% END %]
318
[% INCLUDE 'intranet-bottom.inc' %]
331
[% INCLUDE 'intranet-bottom.inc' %]
(-)a/misc/import_patrons.pl (+3 lines)
Lines 29-34 my $Import = Koha::Patrons::Import->new(); Link Here
29
my $csv_file;
29
my $csv_file;
30
my $matchpoint;
30
my $matchpoint;
31
my $overwrite_cardnumber;
31
my $overwrite_cardnumber;
32
my $overwrite_passwords;
32
my %defaults;
33
my %defaults;
33
my $ext_preserve = 0;
34
my $ext_preserve = 0;
34
my $confirm;
35
my $confirm;
Lines 41-46 GetOptions( Link Here
41
    'm|matchpoint=s'                => \$matchpoint,
42
    'm|matchpoint=s'                => \$matchpoint,
42
    'd|default=s'                   => \%defaults,
43
    'd|default=s'                   => \%defaults,
43
    'o|overwrite'                   => \$overwrite_cardnumber,
44
    'o|overwrite'                   => \$overwrite_cardnumber,
45
    'op|overwrite_passwords'        => \$overwrite_passwords,
44
    'p|preserve-extended-attributes' => \$ext_preserve,
46
    'p|preserve-extended-attributes' => \$ext_preserve,
45
    'v|verbose+'                    => \$verbose,
47
    'v|verbose+'                    => \$verbose,
46
    'h|help|?'                      => \$help,
48
    'h|help|?'                      => \$help,
Lines 61-66 my $return = $Import->import_patrons( Link Here
61
        defaults                     => \%defaults,
63
        defaults                     => \%defaults,
62
        matchpoint                   => $matchpoint,
64
        matchpoint                   => $matchpoint,
63
        overwrite_cardnumber         => $overwrite_cardnumber,
65
        overwrite_cardnumber         => $overwrite_cardnumber,
66
        overwrite_passwords          => $overwrite_passwords,
64
        preserve_extended_attributes => $ext_preserve,
67
        preserve_extended_attributes => $ext_preserve,
65
    }
68
    }
66
);
69
);
(-)a/t/db_dependent/Koha/Patrons/Import.t (-1 / +40 lines)
Lines 18-24 Link Here
18
# along with Koha; if not, see <http://www.gnu.org/licenses>.
18
# along with Koha; if not, see <http://www.gnu.org/licenses>.
19
19
20
use Modern::Perl;
20
use Modern::Perl;
21
use Test::More tests => 157;
21
use Test::More tests => 158;
22
use Test::Warn;
22
use Test::Warn;
23
use Encode qw( encode_utf8 );
23
use Encode qw( encode_utf8 );
24
use utf8;
24
use utf8;
Lines 431-436 subtest 'test_import_with_cardnumber_0' => sub { Link Here
431
431
432
};
432
};
433
433
434
subtest 'test_import_with_password_overwrite' => sub {
435
    plan tests => 4;
436
437
    #Remove possible existing user to avoid clashes
438
    my $ernest = Koha::Patrons->find({ userid => 'ErnestP' });
439
    $ernest->delete if $ernest;
440
441
    #Setup our info
442
    my $branchcode = $builder->build({ source => "Branch"})->{branchcode};
443
    my $categorycode = $builder->build({ source => "Category"})->{categorycode};
444
    my $csv_headers  = 'surname,userid,branchcode,categorycode,password';
445
    my $csv_password = "Worrell,ErnestP,$branchcode,$categorycode,Ernest";
446
    my $csv_password_change = "Worrell,ErnestP,$branchcode,$categorycode,Vern";
447
    my $defaults = { cardnumber => "" }; #currently all the defaults come as "" if not filled
448
449
    #Make the test files for importing
450
    my $filename_1 = make_csv($temp_dir, $csv_headers, $csv_password);
451
    open(my $handle_1, "<", $filename_1) or die "cannot open < $filename_1: $!";
452
    my $params_1 = { file => $handle_1, matchpoint => 'userid', overwrite_passwords => 1, overwrite_cardnumber => 1};
453
    my $filename_2 = make_csv($temp_dir, $csv_headers, $csv_password_change);
454
    open(my $handle_2, "<", $filename_2) or die "cannot open < $filename_2: $!";
455
    my $params_2 = { file => $handle_2, matchpoint => 'userid', overwrite_passwords => 1, overwrite_cardnumber => 1};
456
457
458
    my $result = $patrons_import->import_patrons($params_1, $defaults);
459
    like($result->{feedback}->[1]->{value}, qr/^Worrell \/ \d+/, 'First borrower imported as expected');
460
    $ernest = Koha::Patrons->find({ userid => 'ErnestP' });
461
    isnt($ernest->password,'Ernest',"New patron is imported, password is encrypted");
462
463
    #Save info to double check
464
    my $orig_pass = $ernest->password;
465
466
    $result = $patrons_import->import_patrons($params_2, $defaults);
467
    $ernest = Koha::Patrons->find({ userid => 'ErnestP' });
468
    isnt($ernest->password,$orig_pass,"New patron is overwritten, password is overwritten");
469
    isnt($ernest->password,'Vern',"Password is overwritten and is encrypted from value provided");
470
471
};
472
434
473
435
subtest 'test_prepare_columns' => sub {
474
subtest 'test_prepare_columns' => sub {
436
    plan tests => 16;
475
    plan tests => 16;
(-)a/tools/import_borrowers.pl (-1 / +1 lines)
Lines 127-132 if ( $uploadborrowers && length($uploadborrowers) > 0 ) { Link Here
127
            defaults                     => \%defaults,
127
            defaults                     => \%defaults,
128
            matchpoint                   => $matchpoint,
128
            matchpoint                   => $matchpoint,
129
            overwrite_cardnumber         => $input->param('overwrite_cardnumber'),
129
            overwrite_cardnumber         => $input->param('overwrite_cardnumber'),
130
            overwrite_passwords          => $input->param('overwrite_passwords'),
130
            preserve_extended_attributes => $input->param('ext_preserve') || 0,
131
            preserve_extended_attributes => $input->param('ext_preserve') || 0,
131
        }
132
        }
132
    );
133
    );
133
- 

Return to bug 23473