Bugzilla – Attachment 97182 Details for
Bug 24200
Borrower_PrevCheckout.t failing randomly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24200: Try to fix random failures from Borrower_PrevCheckout.t
Bug-24200-Try-to-fix-random-failures-from-Borrower.patch (text/plain), 1.50 KB, created by
Jonathan Druart
on 2020-01-10 10:49:12 UTC
(
hide
)
Description:
Bug 24200: Try to fix random failures from Borrower_PrevCheckout.t
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-01-10 10:49:12 UTC
Size:
1.50 KB
patch
obsolete
>From 42683800fd4bd33cdfeac48163d36d65953b222c Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 10 Jan 2020 11:48:09 +0100 >Subject: [PATCH] Bug 24200: Try to fix random failures from > Borrower_PrevCheckout.t > >It failed inconsistently, let's try to use build_sample_item and see if >it fixes the random failures. > >Test plan: > % prove t/db_dependent/Patron/Borrower_PrevCheckout.t >must return green >--- > t/db_dependent/Patron/Borrower_PrevCheckout.t | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > >diff --git a/t/db_dependent/Patron/Borrower_PrevCheckout.t b/t/db_dependent/Patron/Borrower_PrevCheckout.t >index d2af210db7..9fabec06e7 100644 >--- a/t/db_dependent/Patron/Borrower_PrevCheckout.t >+++ b/t/db_dependent/Patron/Borrower_PrevCheckout.t >@@ -237,15 +237,9 @@ my $patron_d = $builder->build({source => 'Borrower'}); > > my $biblio = $builder->build_sample_biblio; > $biblio->serial(0)->store; >-my $item_1 = $builder->build({ >- source => 'Item', >- value => { biblionumber => $biblio->biblionumber } >-}); >-my $item_2 = $builder->build({ >- source => 'Item', >- value => { biblionumber => $biblio->biblionumber }, >-}); >-my $item_d = $builder->build({source => 'Item'}); >+my $item_1 = $builder->build_sample_item({biblionumber => $biblio->biblionumber})->unblessed; >+my $item_2 = $builder->build_sample_item({biblionumber => $biblio->biblionumber})->unblessed; >+my $item_d = $builder->build_sample_item->unblessed; > > ## Testing Sub > sub test_it { >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24200
: 97182 |
100954