Bugzilla – Attachment 97363 Details for
Bug 23443
Paying off a lost fee will return the item, even if it is checked out to a different patron
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23443: Do not checkin an item if checked out to another patron when lost fee is paid
Bug-23443-Do-not-checkin-an-item-if-checked-out-to.patch (text/plain), 1.29 KB, created by
ByWater Sandboxes
on 2020-01-14 17:14:31 UTC
(
hide
)
Description:
Bug 23443: Do not checkin an item if checked out to another patron when lost fee is paid
Filename:
MIME Type:
Creator:
ByWater Sandboxes
Created:
2020-01-14 17:14:31 UTC
Size:
1.29 KB
patch
obsolete
>From 1773cdd98be00763afae0da4a76ab0d8368444ca Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 14 Jan 2020 12:39:38 +0100 >Subject: [PATCH] Bug 23443: Do not checkin an item if checked out to another > patron when lost fee is paid > >Test plan: >0 - Do not apply this patch >1 - Check out an item to a patron >2 - Make sure a fee will be charged when lost >3 - Mark the item lost >4 - Make sure the fee will not be refunded on return of the item >5 - Return the item >6 - Check it out to a new patron >7 - Write off the fine for the original patron >=> The item is now checked in >8 - Apply this patch and repeat 1 to 7 >=> The item is still checked out > >Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> >--- > C4/Circulation.pm | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index c3629c2472..068f79b883 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2166,6 +2166,9 @@ sub MarkIssueReturned { > > # Retrieve the issue > my $issue = Koha::Checkouts->find( { itemnumber => $itemnumber } ) or return; >+ >+ return unless $issue->borrowernumber == $borrowernumber; # If the item is checked out to another patron we do not return it >+ > my $issue_id = $issue->issue_id; > > my $anonymouspatron; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23443
:
97342
|
97343
|
97362
|
97363
|
97859
|
97860