From 1c8b45d3c59ab13b1aecf18aa51c566c097e79c7 Mon Sep 17 00:00:00 2001 From: Agustin Moyano Date: Wed, 15 Jan 2020 19:52:53 -0300 Subject: [PATCH] Bug 24432: Regresion test To test: 1. apply this patch 2. prove t/Koha/REST/Plugin/Query.t Test should fail at this point. --- t/Koha/REST/Plugin/Query.t | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/t/Koha/REST/Plugin/Query.t b/t/Koha/REST/Plugin/Query.t index 7bf7c3cca3..1c5064bf2f 100644 --- a/t/Koha/REST/Plugin/Query.t +++ b/t/Koha/REST/Plugin/Query.t @@ -108,6 +108,20 @@ get '/dbic_merge_sorting_result_set' => sub { $c->render( json => $attributes, status => 200 ); }; +get '/dbic_merge_sorting_date' => sub { + my $c = shift; + my $attributes = { a => 'a', b => 'b' }; + my $result_set = Koha::Holds->new; + $attributes = $c->dbic_merge_sorting( + { + attributes => $attributes, + params => { _match => 'exact', _order_by => [ '-hold_date' ] }, + result_set => $result_set + } + ); + $c->render( json => $attributes, status => 200 ); +}; + get '/build_query' => sub { my $c = shift; my ( $filtered_params, $reserved_params ) = @@ -214,7 +228,7 @@ subtest 'extract_reserved_params() tests' => sub { subtest 'dbic_merge_sorting() tests' => sub { - plan tests => 15; + plan tests => 20; my $t = Test::Mojo->new; @@ -240,6 +254,14 @@ subtest 'dbic_merge_sorting() tests' => sub { ] ); + $t->get_ok('/dbic_merge_sorting_date')->status_is(200) + ->json_is( '/a' => 'a', 'Existing values are kept (a)' ) + ->json_is( '/b' => 'b', 'Existing values are kept (b)' )->json_is( + '/order_by' => [ + { -desc => 'hold_date' } + ] + ); + $t->get_ok('/dbic_merge_sorting_single')->status_is(200) ->json_is( '/a' => 'a', 'Existing values are kept (a)' ) ->json_is( '/b' => 'b', 'Existing values are kept (b)' )->json_is( -- 2.17.1