From b5f0b45504fdac8b61bb3e7fa7460853aded4cbf Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Thu, 16 Jan 2020 13:09:58 +0000 Subject: [PATCH] Bug 24377: Record passed branch if renewing via cron To test: 1 - Checkout an item with auto renewal set and eligible for auto renew 2 - Set no renewal before in the circ rules to 99 (something greater than the checkout period) 3 - perl misc/cronjobs/automatic_renewals.pl 4 - Check the statistics table, note the branch for renewal is null SELECT * FROM statistics WHERE itemnumber={itemnumber} AND type='RENEWAL' 5 - Apply patch 6 - Repeat 1-4 7 - Note the branch is set to the issuing branch --- C4/Circulation.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index c3629c2472..d39961a243 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -2987,7 +2987,7 @@ sub AddRenewal { } unless ( C4::Context->interface eq 'opac' ) { #if from opac we are obeying OpacRenewalBranch as calculated in opac-renew.pl - $branch = C4::Context->userenv ? C4::Context->userenv->{branch} : $branch; + $branch = ( C4::Context->userenv && defined C4::Context->userenv->{branch} ) ? C4::Context->userenv->{branch} : $branch; } # Add the renewal to stats -- 2.11.0