From 3f191a265b884f987da42f86c5d4a32586d24424 Mon Sep 17 00:00:00 2001
From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Date: Thu, 16 Jan 2020 15:25:34 +0000
Subject: [PATCH] Bug 24298: Add return enums to branchstransfer triggers

---
 .../data/mysql/atomicupdate/bug_24298.perl    | 23 +++++++++++++++++++
 installer/data/mysql/kohastructure.sql        |  2 +-
 2 files changed, 24 insertions(+), 1 deletion(-)
 create mode 100644 installer/data/mysql/atomicupdate/bug_24298.perl

diff --git a/installer/data/mysql/atomicupdate/bug_24298.perl b/installer/data/mysql/atomicupdate/bug_24298.perl
new file mode 100644
index 0000000000..695354b39d
--- /dev/null
+++ b/installer/data/mysql/atomicupdate/bug_24298.perl
@@ -0,0 +1,23 @@
+$DBversion = 'XXX'; # will be replaced by the RM
+if( CheckVersion( $DBversion ) ) {
+
+    # Add return reasons to enum
+    $dbh->do(
+        qq{
+            ALTER TABLE
+                `branchtransfers`
+            MODIFY COLUMN
+                `reason` enum(
+                    'Manual',
+                    'StockrotationAdvance',
+                    'StockrotationRepatriation',
+                    'ReturnToHome',
+                    'ReturnToHolding'
+                )
+            AFTER `comments`
+          }
+    );
+
+    SetVersion( $DBversion );
+    print "Upgrade to $DBversion done (Bug 24296 - Add 'return' reasons to branchtransfers enum)\n";
+}
diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql
index 8788307e20..827dc822e4 100644
--- a/installer/data/mysql/kohastructure.sql
+++ b/installer/data/mysql/kohastructure.sql
@@ -951,7 +951,7 @@ CREATE TABLE `branchtransfers` ( -- information for items that are in transit be
   `datearrived` datetime default NULL, -- the date the transfer arrived at its destination
   `tobranch` varchar(10) NOT NULL default '', -- the branch the transfer was going to
   `comments` LONGTEXT, -- any comments related to the transfer
-  `reason` ENUM('Manual', 'StockrotationAdvance', 'StockrotationRepatriation'), -- what triggered the transfer
+  `reason` ENUM('Manual', 'StockrotationAdvance', 'StockrotationRepatriation', 'ReturnToHome', 'ReturnToHolding'), -- what triggered the transfer
   PRIMARY KEY (`branchtransfer_id`),
   KEY `frombranch` (`frombranch`),
   KEY `tobranch` (`tobranch`),
-- 
2.20.1