From e65a593d70f0da9d3dcbe6938d44372262da1840 Mon Sep 17 00:00:00 2001
From: Matthias Meusburger <matthias.meusburger@biblibre.com>
Date: Mon, 20 Jan 2020 15:36:21 +0100
Subject: [PATCH] Bug 20888: Follow-up: 'is not' operator behaves as 'not like'

---
 C4/Items.pm                                                     | 3 ++-
 koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt | 8 ++++----
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/C4/Items.pm b/C4/Items.pm
index bd335d5..afc5c43 100644
--- a/C4/Items.pm
+++ b/C4/Items.pm
@@ -2102,6 +2102,7 @@ sub _SearchItems_build_where_fragment {
         push @columns, Koha::Database->new()->schema()->resultset('Biblio')->result_source->columns;
         push @columns, Koha::Database->new()->schema()->resultset('Biblioitem')->result_source->columns;
         my @operators = qw(= != > < >= <= like);
+        push @operators, 'not like';
         my $field = $filter->{field};
         if ( (0 < grep /^$field$/, @columns) or (substr($field, 0, 5) eq 'marc:') ) {
             my $op = $filter->{operator};
@@ -2184,7 +2185,7 @@ A filter has the following keys:
 
 =item * query: the value to search in this column
 
-=item * operator: comparison operator. Can be one of = != > < >= <= like
+=item * operator: comparison operator. Can be one of = != > < >= <= like 'not like'
 
 =back
 
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt
index 1ebe9ad..1ae2a28 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt
@@ -85,16 +85,16 @@
     [% IF params.exists('op') %]
         <select name="op" class="form-field-not">
            <option value="like">is</option>
-            [% IF params.op == '!=' %]
-               <option value="!=" selected="selected">is not</option>
+            [% IF params.op == 'not like' %]
+               <option value="not like" selected="selected">is not</option>
             [% ELSE %]
-               <option value="!=">is not</option>
+               <option value="not like">is not</option>
             [% END %]
         </select>
     [% ELSE %]
         <select name="op" class="form-field-not">
            <option value="like">is</option>
-           <option value="!=">is not</option>
+           <option value="not like">is not</option>
         </select>
     [% END %]
     <input type="text" name="q" class="form-field-value" value="" />
-- 
2.7.4