Bugzilla – Attachment 97656 Details for
Bug 22898
Selenium tests for placing holds from the staff interface
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22898: Fix failure since bug 19618
Bug-22898-Fix-failure-since-bug-19618.patch (text/plain), 1.67 KB, created by
Jonathan Druart
on 2020-01-21 11:58:41 UTC
(
hide
)
Description:
Bug 22898: Fix failure since bug 19618
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-01-21 11:58:41 UTC
Size:
1.67 KB
patch
obsolete
>From 192b100c7ea5ab1e3eb22f1a5a4c1e40f2fdc1a2 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 21 Jan 2020 12:57:01 +0100 >Subject: [PATCH] Bug 22898: Fix failure since bug 19618 > >See comment in the code, this is not the correct fix, but cannot find >something better for now. >--- > t/db_dependent/selenium/basic_workflow.t | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/t/db_dependent/selenium/basic_workflow.t b/t/db_dependent/selenium/basic_workflow.t >index d5aa691d3f..5cb2ab9bda 100644 >--- a/t/db_dependent/selenium/basic_workflow.t >+++ b/t/db_dependent/selenium/basic_workflow.t >@@ -242,12 +242,14 @@ SKIP: { > #Place holds > $driver->get($base_url."/reserve/request.pl?borrowernumber=$borrowernumber&biblionumber=".$biblionumbers[0]); > $driver->find_element('//form[@id="hold-request-form"]//button[@type="submit"]')->click; # Biblio level >+ $driver->pause(1000); # This seems wrong, since bug 19618 the hold is created async with an AJAX call. Not sure what is happening here but the next statements are exectuted before the hold is created and the count is wrong (still 0) > my $patron = Koha::Patrons->find($borrowernumber); > is( $patron->holds->count, 1, ); > > $driver->get($base_url."/reserve/request.pl?borrowernumber=$borrowernumber&biblionumber=".$biblionumbers[1]); > $driver->find_element('//form[@id="hold-request-form"]//input[@type="radio"]')->click; # Item level, there is only 1 item per bib so we are safe > $driver->find_element('//form[@id="hold-request-form"]//button[@type="submit"]')->click; >+ $driver->pause(1000); > is( $patron->holds->count, 2, ); > > time_diff("holds"); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22898
:
89673
|
90208
|
90241
|
97655
|
97656
|
98877
|
98878
|
98879
|
98880
|
98881
|
98882