From f81cbb78a2242a392b75c7f8ce073e8456349d6b Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 18 Mar 2019 14:15:37 -0300 Subject: [PATCH] Bug 23463: Remove _set_defaults_for_add _set_defaults_for_add is no longer needed as it is handled by dbic and koha::object->store --- C4/Items.pm | 43 ------------------------------------------- Koha/Item.pm | 4 ++++ 2 files changed, 4 insertions(+), 43 deletions(-) diff --git a/C4/Items.pm b/C4/Items.pm index db0339c355..5be5ee9b0b 100644 --- a/C4/Items.pm +++ b/C4/Items.pm @@ -202,7 +202,6 @@ sub AddItem { $unlinked_item_subfields = shift; } - _set_defaults_for_add($item); _set_derived_columns_for_add($item); $item->{'more_subfields_xml'} = _get_unlinked_subfields_xml($unlinked_item_subfields); @@ -304,7 +303,6 @@ sub AddItemBatchFromMarc { next ITEMFIELD; } - _set_defaults_for_add($item); _set_derived_columns_for_add($item); my ( $itemnumber, $error ) = _koha_new_item( $item, $item->{barcode} ); warn $error if $error; @@ -1486,47 +1484,6 @@ sub _calc_items_cn_sort { $item->{'items.cn_sort'} = GetClassSort($source_values->{'items.cn_source'}, $source_values->{'itemcallnumber'}, ""); } -=head2 _set_defaults_for_add - - _set_defaults_for_add($item_hash); - -Given an item hash representing an item to be added, set -correct default values for columns whose default value -is not handled by the DBMS. This includes the following -columns: - -=over 2 - -=item * - -C - -=item * - -C - -=item * - -C - -=item * - -C - -=item * - -C - -=back - -=cut - -sub _set_defaults_for_add { - my $item = shift; - $item->{dateaccessioned} ||= output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 1 }); - $item->{$_} ||= 0 for (qw( notforloan damaged itemlost withdrawn)); -} - =head2 _koha_new_item my ($itemnumber,$error) = _koha_new_item( $item, $barcode ); diff --git a/Koha/Item.pm b/Koha/Item.pm index 60d8f935b1..5a6d0c0cc8 100644 --- a/Koha/Item.pm +++ b/Koha/Item.pm @@ -81,6 +81,10 @@ sub store { } + unless ( $self->dateaccessioned ) { + $self->dateaccessioned($today); + } + return $self->SUPER::store; } -- 2.25.0