Bugzilla – Attachment 98103 Details for
Bug 24456
previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder sort incorrectly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24456: change default sort orders/make wording clearer
Bug-24456-change-default-sort-ordersmake-wording-c.patch (text/plain), 2.19 KB, created by
ByWater Sandboxes
on 2020-01-29 22:54:58 UTC
(
hide
)
Description:
Bug 24456: change default sort orders/make wording clearer
Filename:
MIME Type:
Creator:
ByWater Sandboxes
Created:
2020-01-29 22:54:58 UTC
Size:
2.19 KB
patch
obsolete
>From efceab0c90f90560e6c1cbb932fbc1f8c04eebc1 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Fri, 17 Jan 2020 22:12:11 +0000 >Subject: [PATCH] Bug 24456: change default sort orders/make wording clearer > >Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> >--- > .../intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref | 2 +- > svc/checkouts | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >index 6eb5af0660..669c29c27d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >@@ -51,7 +51,7 @@ Circulation: > choices: > asc: earliest to latest > desc: latest to earliest >- - due date. >+ - checkout time. > - > - pref: SpecifyDueDate > choices: >diff --git a/svc/checkouts b/svc/checkouts >index f8fd541f36..16fe6cf9f0 100755 >--- a/svc/checkouts >+++ b/svc/checkouts >@@ -267,13 +267,13 @@ while ( my $c = $sth->fetchrow_hashref() ) { > > @checkouts_today = sort { $a->{timestamp} cmp $b->{timestamp} } @checkouts_today; # latest to earliest > @checkouts_today = reverse(@checkouts_today) >- unless ( C4::Context->preference('todaysIssuesDefaultSortOrder') eq 'desc' ); # earliest to latest >+ if ( C4::Context->preference('todaysIssuesDefaultSortOrder') eq 'desc' ); # earliest to latest > > @checkouts_previous = > sort { $a->{date_due} cmp $b->{date_due} || $a->{timestamp} cmp $b->{timestamp} } > @checkouts_previous; # latest to earliest > @checkouts_previous = reverse(@checkouts_previous) >- unless ( C4::Context->preference('previousIssuesDefaultSortOrder') eq 'desc' ); # earliest to latest >+ if ( C4::Context->preference('previousIssuesDefaultSortOrder') eq 'desc' ); # earliest to latest > > my @checkouts = ( @checkouts_today, @checkouts_previous ); > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24456
:
97580
|
98103
|
100911