Bugzilla – Attachment 98132 Details for
Bug 23493
jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23493: (RM follow-up) Let datatables calculate colspan for us
Bug-23493-RM-follow-up-Let-datatables-calculate-co.patch (text/plain), 1.52 KB, created by
Martin Renvoize
on 2020-01-30 09:44:52 UTC
(
hide
)
Description:
Bug 23493: (RM follow-up) Let datatables calculate colspan for us
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2020-01-30 09:44:52 UTC
Size:
1.52 KB
patch
obsolete
>From b3215b4482ba771ae6fc650220ae226617ad2a3f Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 30 Jan 2020 09:37:55 +0000 >Subject: [PATCH] Bug 23493: (RM follow-up) Let datatables calculate colspan > for us > >Prior to this we arbitrarily set a colspan of 100 for the rowgroup >header row. If we remove the td wrapper from the render function then >datatables will automatically wrap the output in an appropraite td with >cell with fullwidth colspan correctly set. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >index 60ad01d7a3..c1ca172f33 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >@@ -600,9 +600,9 @@ $(document).ready(function() { > "dataSrc": "issued_today", > "startRender": function ( rows, group ) { > if ( group ) { >- return $('<tr/>').append("<td colspan='100%'><strong>" + TODAYS_CHECKOUTS + "</strong></td>"); >+ return TODAYS_CHECKOUTS; > } else { >- return $('<tr/>').append("<td colspan='100%'><strong>" + PREVIOUS_CHECKOUTS + "</strong></td>"); >+ return PREVIOUS_CHECKOUTS; > } > } > }, >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23493
:
92443
|
92444
|
97324
|
97344
|
97694
|
97704
|
98041
|
98042
|
98055
|
98056
|
98118
| 98132