From 94329dce9f3c0b8e47e20ebfaa9c44b6995e960e Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Fri, 17 May 2019 09:30:02 -0500
Subject: [PATCH] Bug 22844: Make the attribute mandatory when editing a patron

Note: I am not confident with this patch, I think it's not polished. I
will not have time to improve it to make it ready for 19.05.00
1. Conflict with bug 20443 (which would have make this change way much
easier!)
2. It does not work :) You will be able to submit the memberentry form
even if the patron attribute is marked as mandatory (??)
3. What about the OPAC?
4. What about repeatable fields? We certainly will need JS code here
5. What about the "Quick add" feature? (I had trouble in the past to not
introduce regression when we played with this template...)

Do not forget to run updatedatabase.pl and regenerate DBIC schema if you
want to play with this patchset.

Signed-off-by: David Nind <david@davidnind.com>
---
 koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 7 ++++++-
 members/memberentry.pl                                            | 1 +
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
index 23a32e0785..5ead1db703 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
@@ -1125,7 +1125,11 @@
             [% END %]
             [% FOREACH patron_attribute IN pa_loo.items %]
                 <li data-category_code="[% patron_attribute.category_code | html %]">
-                    <label for="[% patron_attribute.form_id | html %]">[% patron_attribute.description | html %]: </label>
+                    [% IF patron_attribute.mandatory %]
+                        <label for="[% patron_attribute.form_id | html %]" class="required" required="required">[% patron_attribute.description | html %]: </label>
+                    [% ELSE %]
+                        <label for="[% patron_attribute.form_id | html %]">[% patron_attribute.description | html %]: </label>
+                    [% END %]
                         [% IF ( patron_attribute.use_dropdown ) %]
                             <select id="[% patron_attribute.form_id | html %]" name="[% patron_attribute.form_id | html %]">
                                 <option value=""></option>
@@ -1149,6 +1153,7 @@
                         [% IF ( patron_attribute.repeatable ) %]
                         <a href="#" onclick="clone_entry(this); return false;"><i class="fa fa-fw fa-plus"></i> New</a>
                         [% END %]
+                    [% IF patron_attribute.mandatory %]<span class="required">Required</span>[% END %]
                 </li>
             [% END %]
             [% IF pa_loo.class %]</fieldset>[% END %]
diff --git a/members/memberentry.pl b/members/memberentry.pl
index 902beeb0e8..5dfee1c11f 100755
--- a/members/memberentry.pl
+++ b/members/memberentry.pl
@@ -879,6 +879,7 @@ sub patron_attributes_form {
             repeatable        => $attr_type->repeatable(),
             category          => $attr_type->authorised_value_category(),
             category_code     => $attr_type->category_code(),
+            mandatory         => $attr_type->mandatory(),
         };
         if (exists $attr_hash{$attr_type->code()}) {
             foreach my $attr (@{ $attr_hash{$attr_type->code()} }) {
-- 
2.11.0