From d59a770ffb6044766f950154e081864295a7deef Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 28 Jan 2020 16:35:06 +0100 Subject: [PATCH] Bug 18936: (follow-up2) Make possible to have unlimited value for holds_per_day MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Minna Kivinen Signed-off-by: Joonas Kylmälä --- C4/Reserves.pm | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/C4/Reserves.pm b/C4/Reserves.pm index f84922782e..db910a0c04 100644 --- a/C4/Reserves.pm +++ b/C4/Reserves.pm @@ -393,7 +393,8 @@ sub CanItemBeReserved { biblionumber => $item->biblionumber, } ); - if ( $holds->count() >= $holds_per_record ) { + if ( defined $holds_per_record && $holds_per_record ne '' + && $holds->count() >= $holds_per_record ) { return { status => "tooManyHoldsForThisRecord", limit => $holds_per_record }; } @@ -402,10 +403,9 @@ sub CanItemBeReserved { reservedate => dt_from_string->date }); - if ( defined $holds_per_day && - ( ( $holds_per_day > 0 && $today_holds->count() >= $holds_per_day ) - or ( $holds_per_day == 0 && $holds_per_day ne '') ) - ) { + if ( defined $holds_per_day && $holds_per_day ne '' + && $today_holds->count() >= $holds_per_day ) + { return { status => 'tooManyReservesToday', limit => $holds_per_day }; } @@ -436,7 +436,8 @@ sub CanItemBeReserved { } # we check if it's ok or not - if ( $reservecount >= $allowedreserves ) { + if ( defined $allowedreserves && $allowedreserves ne '' + && $reservecount >= $allowedreserves ) { return { status => 'tooManyReserves', limit => $allowedreserves }; } -- 2.11.0