Bugzilla – Attachment 98363 Details for
Bug 10879
OverDrive should check for OverDriveLibraryID before performing search
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10879: OverDrive should check for OverDriveLibraryID before performing search
Bug-10879-OverDrive-should-check-for-OverDriveLibr.patch (text/plain), 2.03 KB, created by
Katrin Fischer
on 2020-02-04 07:16:34 UTC
(
hide
)
Description:
Bug 10879: OverDrive should check for OverDriveLibraryID before performing search
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2020-02-04 07:16:34 UTC
Size:
2.03 KB
patch
obsolete
>From 93417af173cafa38bad9134865afdb8e3fc906be Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 19 Nov 2019 17:02:02 +0000 >Subject: [PATCH] Bug 10879: OverDrive should check for OverDriveLibraryID > before performing search > >This patch modifies the OPAC search results template to check for three >populated system preferences before performing an OverDrive search: >OverDriveLibraryID, OverDriveClientKey, and OverDriveClientSecret. >Previously OverDriveLibraryID was not checked, but without it the >interface reports an error performing the search. > >To test you must have credentials for the OverDrive API as defined >in OverDriveClientKey, OverDriveClientSecret, and OverDriveLibraryID >system preferences. > > - With OverDriveLibraryID defined, the catalog search results page in > the OPAC should show a link to results in the library's OverDrive > collection. > > - With no value in the OverDriveLibraryID preference the catalog > search page should not show any message about an OverDrive > collection. > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >index 52371ee7fe..ba46f950f4 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >@@ -7,7 +7,7 @@ > [% SET AdlibrisURL = Koha.Preference('AdlibrisCoversURL') %] > > [% IF firstPage %] >- [% SET OverDriveEnabled = Koha.Preference('OverDriveClientKey') && Koha.Preference('OverDriveClientSecret') %] >+ [% SET OverDriveEnabled = Koha.Preference('OverDriveLibraryID') && Koha.Preference('OverDriveClientKey') && Koha.Preference('OverDriveClientSecret') %] > [% SET RecordedBooksEnabled = Koha.Preference('RecordedBooksLibraryID') && Koha.Preference('RecordedBooksClientSecret') %] > [% END %] > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10879
:
95584
|
98191
| 98363